minor update to the repo to ensure running in all machines#14
Draft
MaxHao56 wants to merge 21 commits intoliamhebert:mainfrom
Draft
minor update to the repo to ensure running in all machines#14MaxHao56 wants to merge 21 commits intoliamhebert:mainfrom
MaxHao56 wants to merge 21 commits intoliamhebert:mainfrom
Conversation
liamhebert
requested changes
Oct 3, 2025
Owner
liamhebert
left a comment
liamhebert
left a comment
There was a problem hiding this comment.
Few minor comments on root_dir, which when resolved are good to submit :)
added 2 commits
November 13, 2025 06:41
liamhebert
requested changes
Nov 17, 2025
Owner
liamhebert
left a comment
liamhebert
left a comment
There was a problem hiding this comment.
Still need to review EmbeddingGenerator, more soon.
| """Flatten a discussion tree into tensors for model input.""" | ||
| dut.compute_relative_distance(tree) | ||
|
|
||
| flat = { |
Owner
There was a problem hiding this comment.
We are missing a few parameters here. Namely, is_root and distances. These should be already attributes of node (I think).
Lines 860 to 867 in 5f50b4a
| "out_degree": out_degree, | ||
| "attn_bias": torch.zeros((n, n)), | ||
| "distance": torch.zeros((n, n, 2)), | ||
| "distance_index": torch.zeros((n, n), dtype=torch.int16), |
Owner
There was a problem hiding this comment.
This doesn't feel right... can you double check whether there should be a value here?
| "input_ids": tokenized_text["input_ids"], | ||
| "attention_mask": tokenized_text["attention_mask"], | ||
| "token_type_ids": tokenized_text.get( | ||
| "token_type_ids", torch.zeros_like(tokenized_text["input_ids"]) |
Owner
There was a problem hiding this comment.
likewise, we should be careful here
Replaced manual path setup with rootutils for better management.
Removed comments about batch size command validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional Changes on the side. YAML file in the configs for giga pretrain needs to have match to your directory in you local or cluster machine