Trim the data field of dquotes when finding records#28
Closed
andsens wants to merge 1 commit intolibdns:mainfrom
Closed
Trim the data field of dquotes when finding records#28andsens wants to merge 1 commit intolibdns:mainfrom
andsens wants to merge 1 commit intolibdns:mainfrom
Conversation
The INWX API trims leading and trailing quotes in the data field, so it's not possible to create e.g. TXT records with quoted content
Collaborator
|
Thanks for the PR and for investigating the INWX API behaviour. However, according to the libdns contract, TXT record data should not be passed with surrounding quotes: https://github.com/libdns/libdns/blob/d3609c6996e67a8186b81cb4c797dd8c48d5017c/rrtypes.go#L440-L442
Because of this, records coming from libdns should never contain leading or trailing quotes in the Text field. If they do, that would likely be a bug in the caller rather than something the provider should compensate for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The INWX API trims leading and trailing quotes in the data field, so it's not possible to create e.g. TXT records with quoted content.
Meaning you don't ever want to look for records that have data which is surrounded by quotes.
I don't know if the change covers enough or too much. I have only observed this with TXT records and only with double quotes (single quotes seem to behave normally).
I don't think the failing tests have anything to do with the change since the #27 has the exact same failures.