Skip to content

Decorate error from server with record reference #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihmels merged 1 commit into from
Mar 16, 2026
Merged

Decorate error from server with record reference #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,14 +181,14 @@ func (c *client) createRecord(ctx context.Context, record nameserverRecord, doma
})

if err != nil {
return "", err
return "", fmt.Errorf("failed to create record %s %s: %w", record.Name, record.Type, err)
}

data := nameserverCreateRecordResponse{}
err = json.Unmarshal(response, &data)

if err != nil {
return "", err
return "", fmt.Errorf("failed to parse record creation response for %s %s: %w", record.Name, record.Type, err)
}

return data.ID, nil
Expand All @@ -208,15 +208,23 @@ func (c *client) updateRecord(ctx context.Context, record nameserverRecord) erro
Priority: record.Priority,
})

return err
if err != nil {
return fmt.Errorf("failed to update record %s %s: %w", record.Name, record.Type, err)
}

return nil
}

func (c *client) deleteRecord(ctx context.Context, record nameserverRecord) error {
_, err := c.call(ctx, "nameserver.deleteRecord", nameserverDeleteRecordRequest{
ID: record.ID,
})

return err
if err != nil {
return fmt.Errorf("failed to delete record %s %s: %w", record.Name, record.Type, err)
}

return nil
}

func (c *client) createNameserver(ctx context.Context, domain string, _type string, nameservers []string) error {
Expand Down
Loading