Skip to content

ext: hide statically-linked symbols to prevent llhttp collision #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stanhu wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

ext: hide statically-linked symbols to prevent llhttp collision #1000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ext/rugged/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def self.run_cmake(timeout, args)
Dir.chdir("build") do
# On Windows, Ruby-DevKit is MSYS-based, so ensure to use MSYS Makefiles.
generator = "-G \"MSYS Makefiles\"" if Gem.win_platform?
run_cmake(5 * 60, ".. -DBUILD_TESTS=OFF -DUSE_THREADS=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_C_FLAGS=-fPIC -DCMAKE_BUILD_TYPE=RelWithDebInfo #{cmake_flags.join(' ')} #{generator}")
run_cmake(5 * 60, ".. -DBUILD_TESTS=OFF -DUSE_THREADS=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_C_FLAGS=-fPIC -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_C_VISIBILITY_PRESET=hidden #{cmake_flags.join(' ')} #{generator}")
sys(MAKE)

# "normal" libraries (and libgit2 builds) get all these when they build but we're doing it
Expand All @@ -122,6 +122,10 @@ def self.run_cmake(timeout, args)
else
pcfile = File.join(LIBGIT2_DIR, "build", "libgit2.pc")
$LDFLAGS << " " + `pkg-config --libs --static #{pcfile}`.strip
# Prevent statically-linked symbols (e.g. llhttp) from being exported
# into rugged.so, where they would collide with other gems bundling the
# same library (e.g. llhttp-ffi used by the http gem).
$LDFLAGS << " -Wl,--exclude-libs,ALL" if RbConfig::CONFIG['target_os'] =~ /linux/
end
end
end
Expand Down
Loading