Skip to content

context: skip shutdown eventfd without REST endpoint #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jasonthird wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

context: skip shutdown eventfd without REST endpoint #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,11 @@ impl KrunContext {
/// Spawn a thread to listen for shutdown requests and run the workload. If behaving properly,
/// the main thread will never return from this function.
pub fn run(&self) -> Result<(), anyhow::Error> {
// Get the krun shutdown file descriptor and listen to shutdown requests on a new thread.
let shutdown_eventfd = unsafe { get_shutdown_eventfd(self.id) };
let uri = self.args.restful_uri.clone();

// Only spawn a listener thread if the user specified unix:// or tcp://
// Only create a shutdown eventfd and listener for unix:// or tcp:// endpoints.
if uri.as_ref().is_some_and(|u| *u != RestfulUri::None) {
let shutdown_eventfd = unsafe { get_shutdown_eventfd(self.id) };
thread::spawn(move || status_listener(shutdown_eventfd, uri).unwrap());
}

Expand Down