Conversation
error: manual implementation of `.is_multiple_of()` https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#manual_is_multiple_of
elenaf9
reviewed
Feb 13, 2026
|
|
||
| [workspace.package] | ||
| rust-version = "1.83.0" | ||
| rust-version = "1.88.0" |
Member
There was a problem hiding this comment.
I think we have to bump the version of all our crates because this is a breaking change, right?
Member
There was a problem hiding this comment.
Correct. This would be considered a breaking change so I would suggest bumping the crates to the next version.
This commit bumps the minor version of all crates (except libp2p-identity which maintains its own rust-version) and adds corresponding CHANGELOG entries.
Contributor
Author
|
I've bumped the minor version of all crates, except |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refs #6268
This PR bumps the MSRV to 1.88.0 in order to address a vulnerability in the
timecrate.Notes & open questions
ci.yml.Change checklist