transf: future proof __getitem__#382
Merged
james-d-mitchell merged 3 commits intolibsemigroups:stable-1.3from Feb 3, 2026
Merged
transf: future proof __getitem__#382james-d-mitchell merged 3 commits intolibsemigroups:stable-1.3from
__getitem__#382james-d-mitchell merged 3 commits intolibsemigroups:stable-1.3from
Conversation
Member
Author
|
The two conda jobs will fail until: conda-forge/libsemigroups-feedstock#100 is merged |
Collaborator
|
The conda jobs should now pass, provided they pull the latest version of @james-d-mitchell, perhaps you could cherry pick that commit (3d9e980) into this branch? |
james-d-mitchell
force-pushed
the
fix-transf
branch
from
8093bf9 to
8dd1217
Compare
Member
Author
|
Done, will merge if the CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
__getitem__forTransfetc more future proof against changing the exception type thrown byattoLibsemigroupsException.