fix: improve accessibility semantics in CreateGameWidget#3406
Merged
veloce merged 1 commit intoJul 2, 2026
Merged
Conversation
Wrap each label+button pair in a Semantics widget with container, button, label, and excludeSemantics properties so VoiceOver and TalkBack announce each field as a single grouped element with its current value. Fixes lichess-org#3328
Contributor
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With VoiceOver enabled, the create game panel announces labels and values separately due to geometric traversal order:
❌ "Time Control" → "Variant" → "10+0" → "Standard"
Each label is completely separated from its corresponding input, which is confusing for blind users.
Solution
Wrapped each label+button pair in a Semantics widget so VoiceOver and TalkBack announce each field as a single grouped element with its current value:
✅ "Time control: 10+0" → "Variant: Standard" → "Game mode: Casual" → "Rating filter: -500 / +500"
This follows the existing pattern already established in SettingsListTile (lib/src/widgets/settings.dart:36).
Fixes #3328