display arena tournament that game was/is played in#3412
Draft
HaonRekcef wants to merge 1 commit into
Draft
Conversation
Contributor
|
I assume the mentioned issue is #2521 I converted the PR to a draft, because you're right this issue should be fixed before the PR is merged. |
Collaborator
Author
|
Not exactly the same, but possibly related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displays the tournament name and links to it in various places.
Preview:
Note that there is bug with the tournament sockets. Currently when going to a tournament -> going to a game -> going to the tournament again but by pushing a new screen again not by going back.
This can now happen for example from the tv screen or the archived games. Notice that it doesn't manage to connect to the socket. This issue exists already but this PR will make it happen more likely to occur, before maybe it could only happen from deeplinks.
Video:
Screencast_20260630_170149.webm
I think this issue should probably be investigated before this PR is merged as it is quite likely behavior. I wont be able to investigate it in the next month though as I will be on holidays, if not done until then I could do it.