Skip to content

fix(gui): keep models tabs aligned - #1423

Open
iF2007 wants to merge 1 commit into
lidge-jun:devfrom
iF2007:fix/models-tabs-layout-drift
Open

fix(gui): keep models tabs aligned#1423
iF2007 wants to merge 1 commit into
lidge-jun:devfrom
iF2007:fix/models-tabs-layout-drift

Conversation

@iF2007

@iF2007 iF2007 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Before this fix, the Models catalog tab used the wider 1200px content layout, while the Routing tab fell back to the default 980px layout.
  • As a result, switching between the Models, Combo, and Routing tabs caused visible horizontal page drift (about 36px at a 1294px viewport); similar pages such as Logs and Debug were unaffected.
  • Keep the Models catalog and routing tabs aligned by applying the same visible-panel width rule to both tabs and add a regression test.

Verification

  • ./node_modules/.bin/bun run typecheck
  • ./node_modules/.bin/bun run privacy:scan
  • cd gui && ../node_modules/.bin/bun test tests/models-provider-head.test.ts (4 passed)
  • cd gui && ../node_modules/.bin/bun --bun run lint
  • cd gui && ../node_modules/.bin/bun run build
  • cd docs-site && ../node_modules/.bin/bun install --frozen-lockfile && ../node_modules/.bin/bun run build
  • Browser verification at 1294x714: switching between Models, Combo, and Routing keeps the catalog and routing content at the same horizontal position.
  • Full bun run test: 10126 passed, 7 skipped, 3 unrelated existing/environment failures (two timeouts and one Codex shim assertion).

Models routing tab after the layout fix

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • All CI tests are green on my local testing.

  • I pushed my PR to the latest dev commit.

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

Summary by CodeRabbit

  • Bug Fixes

    • Improved the workspace layout so the main content maintains the correct 1200px width when viewing either the catalog or routing tabs.
  • Tests

    • Added coverage to verify consistent layout behavior across both tabs.

@github-actions github-actions Bot added the intake: hygiene-blocked Deterministic PR hygiene checks failed label Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deterministic hygiene checks failed.

  • unsponsored_surface — This changes an authentication, workflow, release-automation, or dependency surface. MAINTAINERS.md requires security review for these; ask a maintainer to apply maintainer-sponsored once they have reviewed it. Paths: package.json.

@github-actions github-actions Bot added the bug Something isn't working label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Models workspace CSS now applies the 1200px .main-inner width when either the catalog or routing panel is visible. A test verifies the shared selector and the removal of the obsolete catalog-shell selector.

Changes

Models workspace layout

Layer / File(s) Summary
Shared panel layout and regression coverage
gui/src/styles-models-workspace.css:11-21, gui/tests/models-provider-head.test.ts:34-44
The .main-inner rule now targets visible catalog or routing panels without requiring the catalog workspace shell. The test verifies both selectors.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: ingwannu, lidge-jun, wibias

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: keeping the Models catalog and routing tabs aligned in the GUI.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

✅ READY

  • all PR quality gates passed; the review readiness checklist is complete.

Review readiness checklist

  • ✅ All CI tests are green on my local testing.
  • ✅ I pushed my PR to the latest dev commit.
  • ✅ I resolved all correct Codex and CodeRabbit findings.
  • ✅ My PR is ready for review.

4/4 boxes ticked.

This pull request is already Ready for Review.
The review-ready label marks this PR as ready; review automation runs independently. If no CodeRabbit review appears, comment @coderabbitai review to request one.
Maintainers: @lidge-jun @Ingwannu @Wibias

@github-actions
github-actions Bot marked this pull request as draft August 10, 2026 11:33
@iF2007
iF2007 force-pushed the fix/models-tabs-layout-drift branch from 9191097 to b28410b Compare August 10, 2026 11:36
@github-actions github-actions Bot added review-ready and removed intake: hygiene-blocked Deterministic PR hygiene checks failed labels Aug 10, 2026
@github-actions
github-actions Bot marked this pull request as ready for review August 10, 2026 11:40
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions[bot] Acknowledged. The PR is marked Ready for Review, and the reported readiness checklist is complete.

I am replying to the latest comment only. I do not have the full earlier comment chain.

You are interacting with an AI system.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@github-actions[bot] The PR is marked ready for review. I will review the current changes. I am replying to the latest comment only because the complete earlier comment chain is unavailable.

⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions The PR readiness gate is complete. The pull request is already Ready for Review.

You are interacting with an AI system.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions[bot] Acknowledged. The readiness checklist is complete, and the pull request is Ready for Review.

You are interacting with an AI system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working review-ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant