Skip to content

fix(gui): denser Storage, API Access, Subagents, Usage, and Claude layouts #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wibias merged 3 commits into from
Jul 30, 2026
Merged

fix(gui): denser Storage, API Access, Subagents, Usage, and Claude layouts #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
904e670
fix(gui): address Codex review on dense workspaces stack
Wibias Jul 30, 2026
27e3762
fix(gui): clear react-doctor warnings on dense workspaces
Wibias Jul 30, 2026
f0acc36
fix(gui): address CodeRabbit follow-ups on dense workspaces
Wibias Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gui/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,8 @@ export default function App() {
{page === "startup" && <Startup apiBase={API_BASE} />}
{page === "providers" && <Providers apiBase={API_BASE} />}
{page === "models" && <Models apiBase={API_BASE} />}
{page === "combos" && <Combos apiBase={API_BASE} />}
{page === "subagents" && <Subagents apiBase={API_BASE} />}
{page === "combos" && <Combos key={API_BASE} apiBase={API_BASE} />}
{page === "subagents" && <Subagents key={API_BASE} apiBase={API_BASE} />}
{page === "logs" && <Logs apiBase={API_BASE} />}
{page === "usage" && <Usage apiBase={API_BASE} />}
{page === "storage" && <Storage apiBase={API_BASE} />}
Expand Down
271 changes: 271 additions & 0 deletions gui/src/components/apikeys-workspace/ApiKeysWorkspace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,271 @@
/**
* ApiKeysWorkspace — rail + main for the API tab. Overview hosts the existing
* endpoint/auth/generate/models/usage panels; selecting a key opens detail.
*/
import { useEffect, useState } from "react";
import { IconChevron, IconTrash } from "../../icons";
import { useT } from "../../i18n/shared";
import type { ExternalModelRow } from "../../api-access-models";
import {
formatCreatedDate,
type ApiEndpointInfo,
type ApiKeyEntry,
type ModelTestState,
} from "../../pages/api-keys-utils";
import {
ApiKeysEndpointsPanel,
ApiKeysManagePanel,
ApiKeysModelsPanel,
ApiKeysUsagePanel,
} from "../../pages/api-keys-panels";

export interface ApiKeysWorkspaceProps {
keys: ApiKeyEntry[];
keysLoading: boolean;
keysLoadFailed: boolean;
endpoints: ApiEndpointInfo;
claudeCodeEnabled: boolean;
localeTag?: string;
newName: string;
creating: boolean;
newKey: string | null;
copied: boolean;
filteredModels: ExternalModelRow[];
modelsLoading: boolean;
modelsLoadFailed: boolean;
modelQuery: string;
copiedModelId: string | null;
modelTests: Record<string, { state: ModelTestState; detail?: string }>;
onNewNameChange: (value: string) => void;
onCreate: () => void;
onDismissNewKey: () => void;
onCopyKey: () => void;
onDelete: (id: string) => void;
onModelQueryChange: (value: string) => void;
onCopyModelId: (modelId: string) => void;
onTestModel: (model: ExternalModelRow) => void;
sourceLabel: (model: ExternalModelRow) => string;
protocolLabel: (protocol: string) => string;
}

export default function ApiKeysWorkspace({
keys,
keysLoading,
keysLoadFailed,
endpoints,
claudeCodeEnabled,
localeTag,
newName,
creating,
newKey,
copied,
filteredModels,
modelsLoading,
modelsLoadFailed,
modelQuery,
copiedModelId,
modelTests,
onNewNameChange,
onCreate,
onDismissNewKey,
onCopyKey,
onDelete,
onModelQueryChange,
onCopyModelId,
onTestModel,
sourceLabel,
protocolLabel,
}: ApiKeysWorkspaceProps) {
const t = useT();
const [selectedId, setSelectedId] = useState<string | null>(null);
const [confirmDelete, setConfirmDelete] = useState(false);
/** Armed after a short delay so a double-click / retained focus cannot confirm immediately. */
const [confirmArmed, setConfirmArmed] = useState(false);

const selected = selectedId ? (keys.find(k => k.id === selectedId) ?? null) : null;

const clearDeleteConfirm = () => {
setConfirmDelete(false);
setConfirmArmed(false);
};

const showOverview = () => {
setSelectedId(null);
clearDeleteConfirm();
};

useEffect(() => {
if (!confirmDelete) {
setConfirmArmed(false);
return;
}
const timer = window.setTimeout(() => setConfirmArmed(true), 300);
return () => window.clearTimeout(timer);
}, [confirmDelete]);

const handleRequestDelete = () => {
if (!selected) return;
setConfirmDelete(true);
};

const handleConfirmDelete = () => {
if (!selected || !confirmArmed) return;
onDelete(selected.id);
clearDeleteConfirm();
setSelectedId(null);
};

return (
<div className="apikeys-workspace-shell">
<div className="apikeys-workspace-root">
<aside className="apikeys-workspace-rail" aria-label={t("api.title")}>
<div className="apikeys-workspace-rail-header">
<span className="apikeys-workspace-rail-title">
{keysLoading ? t("api.activeKeysLoading") : t("api.activeKeys", { count: keys.length })}
</span>
</div>
<div className="apikeys-workspace-rail-list">
<button
type="button"
className={`apikeys-workspace-rail-row${selectedId === null ? " apikeys-workspace-rail-row--selected" : ""}`}
onClick={showOverview}
aria-current={selectedId === null ? "page" : undefined}
>
<span className="apikeys-workspace-rail-name">{t("api.workspace.overview")}</span>
</button>
{keysLoading ? (
<span className="apikeys-workspace-rail-empty">{t("common.loading")}</span>
) : keys.length === 0 ? (
<span className="apikeys-workspace-rail-empty">
{keysLoadFailed ? t("api.keysLoadFailed") : t("api.workspace.noKeysHint")}
</span>
) : (
keys.map(k => (
<button
key={k.id}
type="button"
className={`apikeys-workspace-rail-row${selectedId === k.id ? " apikeys-workspace-rail-row--selected" : ""}`}
onClick={() => { setSelectedId(k.id); clearDeleteConfirm(); }}
aria-current={selectedId === k.id ? "page" : undefined}
>
<span className="apikeys-workspace-rail-name">{k.name}</span>
<span className="apikeys-workspace-rail-meta">
{k.prefix} · {formatCreatedDate(k.createdAt, localeTag)}
</span>
</button>
))
)}
</div>
</aside>

<section className="apikeys-workspace-main" aria-label={t("api.workspace.details")}>
{selected ? (
<div className="awi-detail">
<div className="awi-detail-toolbar">
<button type="button" className="awi-back" onClick={showOverview}>
<IconChevron className="awi-back-chevron" aria-hidden="true" />
{t("modal.back")}
</button>
</div>
<div className="awi-detail-body">
<div className="awi-detail-head">
<h2 className="awi-detail-title">{selected.name}</h2>
<span className="awi-detail-actions">
{confirmDelete ? (
<>
<button
key="confirm-delete"
type="button"
className="btn btn-danger btn-sm awi-confirm-delete"
onClick={handleConfirmDelete}
disabled={!confirmArmed}
>
<IconTrash /> {t("api.confirm")}
</button>
<button type="button" className="btn btn-ghost btn-sm" onClick={clearDeleteConfirm}>
{t("common.cancel")}
</button>
</>
) : (
<button
key="request-delete"
type="button"
className="btn btn-danger btn-sm"
onClick={handleRequestDelete}
aria-label={t("api.deleteAria")}
>
<IconTrash /> {t("api.workspace.deleteKey")}
</button>
)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</span>
</div>
{confirmDelete && (
<p className="muted awi-delete-hint">{t("api.workspace.deleteConfirm")}</p>
)}
<div className="awi-section">
<h3 className="awi-section-title">{t("api.workspace.keyDetails")}</h3>
<dl className="awi-kv">
<div className="awi-kv-row">
<dt>{t("api.colName")}</dt>
<dd>{selected.name}</dd>
</div>
<div className="awi-kv-row">
<dt>{t("api.workspace.keyPrefix")}</dt>
<dd><code>{selected.prefix}</code></dd>
</div>
<div className="awi-kv-row">
<dt>{t("api.colCreated")}</dt>
<dd>{formatCreatedDate(selected.createdAt, localeTag)}</dd>
</div>
</dl>
</div>
</div>
</div>
) : (
<div className="awi-overview">
<div className="awi-overview-left">
<ApiKeysManagePanel
keys={keys}
keysLoading={keysLoading}
keysLoadFailed={keysLoadFailed}
newName={newName}
creating={creating}
newKey={newKey}
copied={copied}
confirmDelete={null}
localeTag={localeTag}
showKeyList={false}
onNewNameChange={onNewNameChange}
onCreate={onCreate}
onDismissNewKey={onDismissNewKey}
onCopyKey={onCopyKey}
onConfirmDelete={() => {}}
onCancelDelete={() => {}}
onDelete={() => {}}
/>
Comment on lines +227 to +245

@coderabbitai coderabbitai Bot Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Four stubbed props are dead plumbing here — make them optional in ApiKeysManagePanel.

With showKeyList={false}, ApiKeysManagePanel renders only the new-key/generate blocks (see gui/src/pages/api-keys-panels.tsx Lines 302-342 — confirmDelete, onConfirmDelete, onCancelDelete, onDelete are read exclusively inside the showKeyList && branch). So confirmDelete={null} plus three () => {} stubs exist only to satisfy a required-prop contract. That's a trap: if someone later reads one of those props outside the list branch, the workspace silently no-ops instead of failing a type check.

Suggested contract tightening in gui/src/pages/api-keys-panels.tsx:

-  confirmDelete: string | null;
+  confirmDelete?: string | null;
   localeTag?: string;
   /** When false, only generate / reveal-new-key UI is shown (workspace rail owns the list). */
   showKeyList?: boolean;
   onNewNameChange: (value: string) => void;
   onCreate: () => void;
   onDismissNewKey: () => void;
   onCopyKey: () => void;
-  onConfirmDelete: (id: string) => void;
-  onCancelDelete: () => void;
-  onDelete: (id: string) => void;
+  onConfirmDelete?: (id: string) => void;
+  onCancelDelete?: () => void;
+  onDelete?: (id: string) => void;

Then drop the four stub props from this call site.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@gui/src/components/apikeys-workspace/ApiKeysWorkspace.tsx` around lines 203 -
221, Update the ApiKeysManagePanel props contract in api-keys-panels.tsx to make
confirmDelete, onConfirmDelete, onCancelDelete, and onDelete optional while
preserving their required use within the showKeyList branch. Remove these four
stub props from the ApiKeysManagePanel invocation in ApiKeysWorkspace; leave all
other props unchanged.

<ApiKeysEndpointsPanel endpoints={endpoints} claudeCodeEnabled={claudeCodeEnabled} />
<ApiKeysUsagePanel endpoints={endpoints} claudeCodeEnabled={claudeCodeEnabled} />
</div>
<div className="awi-overview-right">
<ApiKeysModelsPanel
filteredModels={filteredModels}
modelsLoading={modelsLoading}
modelsLoadFailed={modelsLoadFailed}
modelQuery={modelQuery}
copiedModelId={copiedModelId}
modelTests={modelTests}
claudeCodeEnabled={claudeCodeEnabled}
onModelQueryChange={onModelQueryChange}
onCopyModelId={onCopyModelId}
onTestModel={onTestModel}
sourceLabel={sourceLabel}
protocolLabel={protocolLabel}
/>
</div>
</div>
)}
</section>
</div>
</div>
);
}
Loading
Loading