mp3dec_load_cb: clamp VBR frame count to size_t (32-bit OOB write) - #150
Open
yuunnn wants to merge 1 commit into
Open
mp3dec_load_cb: clamp VBR frame count to size_t (32-bit OOB write)#150yuunnn wants to merge 1 commit into
yuunnn wants to merge 1 commit into
Conversation
Malicious Xing/Info frames value makes detected_samples huge; allocated += detected_samples*sizeof(sample) wraps size_t on 32-bit builds and yields a tiny buffer -> heap-buffer-overflow in mp3d_synth_pair. 64-bit unaffected. Refs lieff#140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crafted Xing/Info tag with huge
frames->detected_samplesup to ~4.9e12.allocated += detected_samples*sizeof(sample)wrapssize_ton 32-bit builds,malloc() gets a tiny buffer, first decoded frame writes 4608 bytes past it.
64-bit unaffected. After fix:
MP3D_E_MEMORYon crafted input.Related: #140 (DoS only; this is the memory-corruption side).