Skip to content

docs: categorical metadata distribution and filtering feature spec - #1738

Open
ikondrat wants to merge 1 commit into
kondrat-lig-9585-frontend-categorical-metadata-bar-chart-filter-ui-8-sp.p12from
kondrat-lig-9585-frontend-categorical-metadata-bar-chart-filter-ui-8-sp.p13
Open

docs: categorical metadata distribution and filtering feature spec#1738
ikondrat wants to merge 1 commit into
kondrat-lig-9585-frontend-categorical-metadata-bar-chart-filter-ui-8-sp.p12from
kondrat-lig-9585-frontend-categorical-metadata-bar-chart-filter-ui-8-sp.p13

Conversation

@ikondrat

Copy link
Copy Markdown
Contributor

Summary

Stacked on p12. Docs-only PR.

Adds docs/features/lig-9585-categorical-metadata-distribution-filter.md — the full feature spec for the categorical distribution panel (LIG-9585). Covers:

  • Distribution panel layout and categorical group rendering
  • Filter interaction and chip labels
  • Bucket edge cases (__missing__, __other__, literal collisions)
  • Visual states (selected, unselectable, dimmed)
  • Configuration (top-N, sort, manual selection, orientation)
  • Filter visibility (full-distribution background bars)
  • Decision rationale

Test plan

  • Docs render correctly on GitHub

Part of LIG-9585.

@ikondrat
ikondrat requested a review from a team as a code owner July 22, 2026 16:11
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e64ff1b9-ba61-4bc8-a1b8-f6e9940f904d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kondrat-lig-9585-frontend-categorical-metadata-bar-chart-filter-ui-8-sp.p13

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lightly-fast-track-bot

lightly-fast-track-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

✅ Fast Track: all required checks passed — auto-approved.

Guardrail Result Message
dummy Always passes.
frontend/complexity 0 file(s) checked.
backend/complexity 0 file(s) checked.
backend/coverage 0 file(s) checked.
diff-size PR adds 215 line(s) (limit: 215).
frontend/coverage 0 file(s) checked.

Reflects c2eea76.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a34385ef5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1,215 @@
# Feature: Categorical Metadata Distribution and Filter

**Status:** Implemented; QA ready

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align the status with the unchecked acceptance criteria

With the spec marked Implemented; QA ready, leaving every acceptance criterion unchecked makes the document read as if none of the shipped behavior has been verified, which is confusing for QA and future readers. Either mark the implemented criteria as complete or change the status to reflect that validation is still pending.

AGENTS.md reference: AGENTS.md:L39-L41

Useful? React with 👍 / 👎.

Comment on lines +77 to +78
- Concrete values are ordered by the endpoint (frequency with deterministic ties). **Missing** and
non-zero **Other** are appended as semantic buckets.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep semantic bucket ordering in sync with the UI

Because this spec is marked implemented, saying Missing and Other are appended is inaccurate for the current panel: categorical buckets are passed through selectVisibleCounts, which sorts all buckets by count/name and only uses pinned to keep Missing/Other included in top-N, so a high-count Missing or Other bucket can render above concrete values. Update the spec or the rendering so the documented ordering matches the product.

Useful? React with 👍 / 👎.

Comment on lines +181 to +183
- `useCategoricalMetadataDistribution.ts` parallels the numeric hook, calls
`POST /metadata/value-counts`, forwards the reactive `ImageFilter`, maps semantic buckets without
label-based identity, and keeps prior data during refetch.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the collection-scoped value-counts endpoint

The implemented route is collection-scoped (/collections/{collection_id}/metadata/value-counts), and the generated client requires that collection_id path parameter. Documenting the hook as calling POST /metadata/value-counts points implementers at a non-existent endpoint, so the contract should include the full collection-scoped path.

Useful? React with 👍 / 👎.

@ikondrat
ikondrat force-pushed the kondrat-lig-9585-frontend-categorical-metadata-bar-chart-filter-ui-8-sp.p13 branch from 7a34385 to c2eea76 Compare July 22, 2026 17:06
@ikondrat
ikondrat force-pushed the kondrat-lig-9585-frontend-categorical-metadata-bar-chart-filter-ui-8-sp.p12 branch from 20d7d76 to 58efaf1 Compare July 22, 2026 17:06
@lightly-fast-track-bot
lightly-fast-track-bot Bot dismissed their stale review July 22, 2026 17:07

Fast Track checks no longer pass; dismissing the bot approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant