feat: use dynamic labels for PanelHeader - #1807
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthrough
ChangesDistribution panel label customization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/review |
❌ Fast Track: checks did not pass
To run the guardrails locally, from Reflects |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lightly_studio_view/src/lib/components/DatasetDistributionPanel/PanelHeader/PanelHeader.test.ts (1)
47-60: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the custom singular noun.
This test renders five categories, so it only exercises
categoryNounPlural;categoryNounis selected only whenclassCount === 1. Add a one-category assertion usingcategoryNoun: 'value'to catch regressions in the singular branch.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lightly_studio_view/src/lib/components/DatasetDistributionPanel/PanelHeader/PanelHeader.test.ts` around lines 47 - 60, Add coverage for the singular category wording in the PanelHeader tests by rendering or configuring a one-category case with categoryNoun set to “value” and asserting the displayed text uses the singular noun. Keep the existing five-category plural assertion unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@lightly_studio_view/src/lib/components/DatasetDistributionPanel/PanelHeader/PanelHeader.test.ts`:
- Around line 47-60: Add coverage for the singular category wording in the
PanelHeader tests by rendering or configuring a one-category case with
categoryNoun set to “value” and asserting the displayed text uses the singular
noun. Keep the existing five-category plural assertion unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e86f6b1a-cc45-45f6-b282-113a960f3b20
📒 Files selected for processing (2)
lightly_studio_view/src/lib/components/DatasetDistributionPanel/PanelHeader/PanelHeader.sveltelightly_studio_view/src/lib/components/DatasetDistributionPanel/PanelHeader/PanelHeader.test.ts
What has changed and why?
Changes in PanelHeader component to reuse it for categorical metadata
How has it been tested?
By unit tests, no bracking changes
Did you update CHANGELOG.md?
Summary by CodeRabbit
New Features
Bug Fixes