Add ONNX and TensorRT export for LT-DETR instance segmentation - #861
Conversation
|
/review |
liopeer
left a comment
There was a problem hiding this comment.
LGTM! In the future we should not have orig_target_size in the exported model anyway. The model graph should only forward the image and yield class logits and box coordinates, working on this in #860, but this will take some time (and likely a design doc as well).
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fa4dc6f1c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d144269d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9d14426 to
ae8e2dd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0b96bcac2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d0b96bc to
a4b5977
Compare
What has changed and why?
Add ONNX and TensorRT export support for LT-DETR instance segmentation.
Note: it now exports both
imagesandorig_target_sizeinputs so predicted boxes and masks can be scaled to the caller-provided image size - something listed as TODO in object detection. The TensorRT helper now configures matching optimization profiles for additional inputs with dynamic batch dimensions, such asorig_target_size, while rejecting unsupported dynamic non-batch dimensions.How has it been tested?
Detections are aligned order-independently using labels, boxes, and scores.
Did you update CHANGELOG.md?
Did you update the documentation?