Bump LDK to 0.3.0-beta1 - #1008
Open
tnull wants to merge 1 commit into
Open
Conversation
Track the first LDK 0.3 beta and its matching payment-instructions revision. Preserve Esplora configuration across the client versions and expose splice negotiation only to local contributors, as defined by the beta API. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @jkczyz as a reviewer! |
jkczyz
reviewed
Jul 30, 2026
| /// A channel splice with local inputs or outputs has been negotiated and the funding | ||
| /// transaction is pending confirmation on-chain. | ||
| /// | ||
| /// This event is not emitted when only the counterparty contributes to a splice. |
Contributor
There was a problem hiding this comment.
Same for SpliceNegotiationFailed?
| skimmed_fee_msat, | ||
| claim_from_onchain_tx, | ||
| outbound_amount_forwarded_msat, | ||
| outbound_amount_forwarded_msat: Some(outbound_amount_forwarded_msat), |
Contributor
There was a problem hiding this comment.
Should we remove the Option from the LDK Node event, too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track the first LDK 0.3 beta and its matching payment-instructions revision. Preserve Esplora configuration across the client versions and expose splice negotiation only to local contributors, as defined by the beta API.
Co-Authored-By: HAL 9000