Create dist-pack before packing into it - #12
Merged
Conversation
The v0.2.0 release failed here: npm error enoent ENOENT: no such file or directory, open '/home/runner/work/orvix/orvix/dist-pack/orvix-0.2.0.tgz' `npm pack --pack-destination` writes into the directory but does not create it, and a fresh runner has no dist-pack. Reproducible anywhere with an empty directory; it passed locally only because the destination happened to exist. The workflow had never run before — 0.1.0 was never tagged — so nothing had exercised this line. ci.yml packs into /tmp, which always exists, which is why the packaged-install job kept passing and hid the gap. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.2.0 release failed at the pack step:
npm pack --pack-destinationwrites into the directory but does not create it, and a fresh runner has nodist-pack. Reproduced in an empty directory:Why nothing caught it
The release workflow had never run — 0.1.0 was never tagged, and there are no releases on the repository. This line had simply never executed.
ci.ymlpacks too, but into/tmp, which always exists. That is why thepackaged installjob has been green all along while the release path was broken.After merging
The
v0.2.0tag is already pushed and points at a commit without this fix, so re-running the failed job would fail the same way. The tag has to move:git checkout main && git pull git tag -d v0.2.0 git push origin :refs/tags/v0.2.0 git tag v0.2.0 git push origin v0.2.0package.jsonis already at 0.2.0 onmain, sonpm versionmust not be run again — the tag-matches-package.json check would still pass, but the version would be bumped twice.