Protect transfer.kill() the way transfer.abort() is protected#2028
Open
karlseguin wants to merge 1 commit intomainfrom
Open
Protect transfer.kill() the way transfer.abort() is protected#2028karlseguin wants to merge 1 commit intomainfrom
karlseguin wants to merge 1 commit intomainfrom
Conversation
Transfer.abort() is protected from aborting the transfer while inside of a libcurl callback (since libcurl doesn't support mutating the easy while inside of a callback AND it causes issues in the zig code). This applies similar logic to Transfer.kill() which is less likely to be called but worse if it is called in a callback, as transfer.kill() deinit's the transfer - something the callback caller is not expecting. Since killing isn't safe to do, we flag the transfer as aborted AND null/noop all the callbacks. Fixes WPT crash /content-security-policy/frame-src/frame-src-blocked-path-matching.sub.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transfer.abort() is protected from aborting the transfer while inside of a libcurl callback (since libcurl doesn't support mutating the easy while inside of a callback AND it causes issues in the zig code).
This applies similar logic to Transfer.kill() which is less likely to be called but worse if it is called in a callback, as transfer.kill() deinit's the transfer - something the callback caller is not expecting. Since killing isn't safe to do, we flag the transfer as aborted AND null/noop all the callbacks.
Fixes WPT crash /content-security-policy/frame-src/frame-src-blocked-path-matching.sub.html