Feature/976 resource relation templates - #1019
Merged
Merged
Conversation
BeriBoss
force-pushed
the
feature/976-resource-relation-templates
branch
2 times, most recently
from
June 29, 2026 14:55
6336673 to
b4de437
Compare
StephGit
reviewed
Jul 7, 2026
StephGit
reviewed
Jul 7, 2026
StephGit
reviewed
Jul 7, 2026
StephGit
reviewed
Jul 7, 2026
StephGit
reviewed
Jul 7, 2026
StephGit
reviewed
Jul 7, 2026
StephGit
reviewed
Jul 7, 2026
StephGit
left a comment
StephGit
left a comment
Contributor
There was a problem hiding this comment.
All in all great work, some minor findings
BeriBoss
force-pushed
the
feature/976-resource-relation-templates
branch
from
July 13, 2026 11:39
64500f0 to
4be2bb6
Compare
StephGit
reviewed
Jul 14, 2026
| } | ||
|
|
||
| isLoading = computed(() => { | ||
| return !(this.relation() != null && this.resource() != null && this.contextId() != null); |
Contributor
There was a problem hiding this comment.
Suggested change
| return !(this.relation() != null && this.resource() != null && this.contextId() != null); | |
| isLoading = computed(() => | |
| this.relation() == null || this.resource() == null || this.contextId() == null; | |
| }); |
same with resource-type-relatioin-templates-list
sorry not properly applyable due to github suggestion limitation
StephGit
reviewed
Jul 14, 2026
|
|
||
| constructor() { | ||
| effect(() => { | ||
| if (this.contextId() != null) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (this.contextId() != null) { | |
| constructor() { | |
| effect(() => { | |
| this.resourceRelationsService.setIdsForResourceRelationTemplates( | |
| this.resource().id, | |
| this.relation().id | |
| ); | |
| }); | |
| } |
The effect runs after first change detection run, so the required inputs should be set. There are situations where values it could be undefined, but this shouldn't be the case using signales throughout
same with resource-type-relatioin-templates-list
sorry not properly applyable due to github suggestion limitation
StephGit
approved these changes
Jul 14, 2026
StephGit
left a comment
StephGit
left a comment
Contributor
There was a problem hiding this comment.
all good, please squash and merge 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.