Skip to content

Experimental plus chromeless combat#3

Open
lilacLunatic wants to merge 1136 commits intodevelopfrom
experimental-plus-chromeless-combat
Open

Experimental plus chromeless combat#3
lilacLunatic wants to merge 1136 commits intodevelopfrom
experimental-plus-chromeless-combat

Conversation

@lilacLunatic
Copy link
Copy Markdown
Owner

@lilacLunatic lilacLunatic commented Dec 30, 2022

sonoftunk and others added 30 commits November 29, 2022 20:49
- Vanilla items show in check tracker, even if many won't auto check
- Fixes an issue with Gerudo Fortress Keys
- Refactors IsVisibleInCheckTracker to randomizer_check_tracjer
lilacLunatic and others added 25 commits December 26, 2022 16:59
lilacLunatic added a commit that referenced this pull request Feb 6, 2023
lilacLunatic pushed a commit that referenced this pull request Aug 25, 2024
* Fix hint generation bugs on develop-rando

1. Fixed Ganon Non-hint text from loading as Saria's Magic Hint.
2. Fixed Ganon Non-hint text from not getting saved correctly.
3. Fixed gossip stone hint generation from not generating any non-always hints on No Logic.

For #3, the hint distribution and placement algorithm was bailing out too early when it wasn't able
to place a hint. For No Logic, what it was doing was failing to place WOTH hints (since No Logic seeds
don't calculate WOTH candidacy), returning the amount of hints it failed to place, and then it called
the function to redistribute the hints, but did not call the function to attempt to place the remaining hints.

Additionally, it was not accounting for the fact that we shouldn't redistribute the hints into the categories we failed to
place a hint in, so it would redistribute hints right back into those categories. I changed it so that when DistributeHints
gets called after PlaceHints fails to place the hint, it checks if the distribution settings copies attribute was set to 0.
In this case, it breaks while looping for the type distribution settings, and moves on to the next category. Also, it now repeatedly
attempts to distribute and place hints until PlaceHints returns 0 (meaning it placed all of its hints successfully).

* Fixes some further seed-bleed type issues with hint generation.
lilacLunatic pushed a commit that referenced this pull request Oct 5, 2024
lilacLunatic pushed a commit that referenced this pull request Jan 7, 2025
Rewrite game interfacing code of fairy shuffle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants