Skip to content

Add vector mini-menu and optimise font as well as some other issues#5

Open
Talark-Systems wants to merge 31 commits intolilbud:masterfrom
Talark-Systems:master
Open

Add vector mini-menu and optimise font as well as some other issues#5
Talark-Systems wants to merge 31 commits intolilbud:masterfrom
Talark-Systems:master

Conversation

@Talark-Systems
Copy link
Copy Markdown

Fixes:

  • Fixed squished gamecard bug in 4:3 mode

Additions/Changes:

  • Changed colour scheme (more accurate with real Switch)
  • Changed gamecard from svg to png (fixes resizing issue)

@Talark-Systems Talark-Systems marked this pull request as ready for review June 1, 2020 17:11
@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 1, 2020

I made the arrow block an svg because svg can scale losslessly to any size with no quality loss. PNG can only scale so far and look good.

Could you send me a copy of your modified theme? It'll help me better see the changes you made.

@Talark-Systems
Copy link
Copy Markdown
Author

Talark-Systems commented Jun 1, 2020

How? It should be visible to you

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 1, 2020

Whoops, forgot that I can download it.

A few things:
See if you can find a higher quality profile pic for the top corner, the current one is pretty low res.
Either change the arrow block back to svg, or make yours svg. as yours is rough looking.

@Talark-Systems
Copy link
Copy Markdown
Author

Talark-Systems commented Jun 1, 2020

Define... “rough?” I exported the svg as a 4K image or at least I thought I did...

Also: I completely forgot about the profile pic... will do!

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 1, 2020

PNG scaling isn't the best in ES, so no matter the size of the png, it will naturally look rough when scaled. That is why I used vector for nearly every image that I could. It can scale to any resolution and look good. Screenshot attached, yours on top.
image
Also, loading an image that big might cause problems on lower powered devices like the earlier Pi's.

@Talark-Systems
Copy link
Copy Markdown
Author

Could you explain why this is... that’s what I was trying to get rid off:
image

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 1, 2020

Just checked, I defined the size for the arrow block in the main theme xml and in the 4_3 and 16_9 xml. Since the main theme xml takes precedence, the other ones aren't used.

I committed a change to the theme xml removing the and lines. Do the same to your fork.

@Talark-Systems
Copy link
Copy Markdown
Author

Will do, thanks!

@Talark-Systems
Copy link
Copy Markdown
Author

Talark-Systems commented Jun 3, 2020

@lilbud try this theme: a beta version of this theme
Also, send me that profile pic please
Also, I realise that ports and setup icons are different, that is because I am using that theme for a project of mine

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 3, 2020

a9d2e63f-f326-4e4f-aa3d-e748f50bb29d

@Talark-Systems
Copy link
Copy Markdown
Author

Thanks, what do you think of the theme, it doesn't have a profile pic yet though...

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 3, 2020

Looks good, but the metadata needs to be adjusted for the new font you used.
image

Compared to the old font
image

Also, It looks weird, the new font looks a bit "jaggy"

@Talark-Systems
Copy link
Copy Markdown
Author

Talark-Systems commented Jun 3, 2020

Umm... What do you mean by that? I'm not sure if that's theme-adjustable...
Also, define 'jaggy'

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 3, 2020

Never mind, it was just the resolution.

The spacing still needs to be fixed, things like the date are too close to the text for date. same with the dev and genre

@Talark-Systems
Copy link
Copy Markdown
Author

How would I fix that... also, do you have a tool to calculate the ES theme position of stuff
like 0.56 and 0.4 stuff

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 3, 2020

I guess just adjust the x position of the metadata text. Not the metadata label, the metadata value itself. Which might need to be done on both the 4_3 and 16_9 xml.

Faster alternative would be to switch back to the Oxygen font.

There used to be a site for converting pixel values to the ES decimal values, I don't have the link. I'll see if I can find it

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 3, 2020

Here is a program made by Rookervik. You can load an image (a mockup lets say) and find the percent values for positioning different components.

Downside, you have to use your mouse to find the values.

https://github.com/lilbud/es-theme-switch-new-files/blob/master/ES%20Theme%20Helper.exe

@Talark-Systems
Copy link
Copy Markdown
Author

I do not quite understand why the Y value of text that has to be next to each other has to be different (genre, date, release, e.t.c)

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 10, 2020

I do not quite understand why the Y value of text that has to be next to each other has to be different (genre, date, release, e.t.c)

I have no idea either, and I don't think I've ever gotten an answer on the forum.

Just line the text up so that the bottom of the text matches the label text

@Talark-Systems
Copy link
Copy Markdown
Author

That did not work......................................

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 10, 2020

Yeah, you might be able to ask on the forum and maybe have to file an issue on the ES github

@Talark-Systems
Copy link
Copy Markdown
Author

Knowing that the last ES update was in 2016, I think the forums are going to be more helpful...

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 10, 2020

Actually, ES has been getting updates pretty recently. Retropie has their own fork of ES which is actively worked on (Jools pushed a commit 2 days ago)
https://github.com/RetroPie/EmulationStation

@Talark-Systems
Copy link
Copy Markdown
Author

And yet, there is still no touchscreen support... -_-

When will us retropiers be able to make a Nintendo Switch?

@Talark-Systems
Copy link
Copy Markdown
Author

Talark-Systems commented Jun 10, 2020

Do they actually look at feature requests...
image
Not one comment...

(I suppose it would be quite hard due to the way ES is made but the devs should still have plans for it...)

@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 10, 2020

Then make a post on the forum, as many of the devs are active there. They'll probably say to file an issue on github, but the post on the forum makes it so that everyone knows.

@Talark-Systems
Copy link
Copy Markdown
Author

I already did

@Talark-Systems
Copy link
Copy Markdown
Author

@lilbud This is the zoid theme:
image

And the y values for the metadata is the same...

@Talark-Systems
Copy link
Copy Markdown
Author

Code in zoid theme:

<text name="md_lbl_rating">
			<pos>0.177 0.21</pos>
		</text>
		
		<text name="md_lbl_releasedate">
			<pos>0.177 0.25</pos>
		</text>
		
		<text name="md_lbl_developer">
			<pos>0.177 0.29</pos>
			<size>0.133 0.04</size>
		</text>

		<text name="md_lbl_publisher">
			<pos>0.177 0.33</pos>
			<size>0.133 0.04</size>
		</text>
		
		<text name="md_lbl_genre">
			<pos>0.177 0.37</pos>
		</text>
		
		<text name="md_lbl_players">
			<pos>0.177 0.41</pos>
		</text>

		<text name="md_lbl_lastplayed">
			<pos>0.177 0.45</pos>
		</text>

		<text name="md_lbl_playcount">
			<pos>0.177 0.49</pos>
		</text>
		
		<text name="md_playcount">
			<pos>0.31 0.49</pos>
		</text>

		<datetime name="md_lastplayed">
			<pos>0.31 0.45</pos>
		</datetime>
		
		<text name="md_players">
			<pos>0.31 0.41</pos>
		</text>
		
		<text name="md_genre">
			<pos>0.31 0.37</pos>
			<size>0.24 0.04</size>
		</text>

		<text name="md_publisher">
			<pos>0.31 0.33</pos>
			<size>0.24 0.04</size>
		</text>
		
		<text name="md_developer">
			<pos>0.31 0.29</pos>
			<size>0.24 0.04</size>
		</text>
		
		<datetime name="md_releasedate">
			<pos>0.31 0.25</pos>
		</datetime>

@Talark-Systems
Copy link
Copy Markdown
Author

Talark-Systems commented Jun 14, 2020

I borrowed some code from the Zoid theme:

<text name="md_lbl_rating, md_lbl_releasedate, md_lbl_developer, md_lbl_publisher, md_lbl_genre, md_lbl_players, md_lbl_lastplayed, md_lbl_playcount">
			<color>393a3b</color>
			<forceUppercase>1</forceUppercase>
			<fontPath>./art/OPENSANS-LIGHT.TTF</fontPath>
			<fontSize>0.03</fontSize>
			<size>0.12 0.04</size>
		</text>
		
		<text name="md_rating, md_developer, md_publisher, md_genre, md_players, md_playcount">
			<color>393a3b</color>
			<forceUppercase>1</forceUppercase>
			<fontPath>./art/OPENSANS-LIGHT.TTF</fontPath>
			<fontSize>0.03</fontSize>
			<size>0.14 0.04</size>
		</text>

(The size part)

And, it worked:
image

Which is wierd... but now, I only have to adjust the X value

@Talark-Systems
Copy link
Copy Markdown
Author

How is this?
image

@Talark-Systems
Copy link
Copy Markdown
Author

Talark-Systems commented Jun 14, 2020

I have borrowed some code from the Zoid theme to fix the metadata and after some more optimisations, I beleive that all that is left to do is to add the user icon and fix the 4:3 metadata text:

Dark mode:
image
image

Light mode:
image
image

4:3 mode:
image
image

@Talark-Systems Talark-Systems changed the title The fixes and improvments pull request which is taking longer than it should but it also adds some more stuff Add vector mini-menu and optimise font as well as some other issues Jun 14, 2020
@lilbud
Copy link
Copy Markdown
Owner

lilbud commented Jun 16, 2020

I'd say make the icons a little smaller on both 4:3 and 16:9.

And also move the "released" metadata down a bit so it's centered in between the developer and genre text.
(I wasn't getting email notifications until now)

@Talark-Systems
Copy link
Copy Markdown
Author

Talark-Systems commented Jul 8, 2020

I have made some changes to this other repo, I am now working on the user icon and the mini-menu

[EDIT: I have updated the repo in this pull request to match the other one]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants