chore(ecc): add ECC developer profile configuration#424
Conversation
ECC analysis detected: TypeScript + Python + React + Docker + GitHub Actions. Resolves audit findings (80/100 → 100/100): - Add missing rules/python/ (coding-style, patterns, security, testing) - Add 5 missing skills: frontend-patterns, frontend-slides, python-patterns, python-testing, e2e-testing - Add full ECC developer profile: 17 agents, 44 commands, 19 rules, 31 scripts, 21 skills, hooks configuration
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae919829fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| 'use strict'; | ||
|
|
||
| const fs = require('fs'); |
There was a problem hiding this comment.
This file is executed with node from .claude/hooks/hooks.json, but it uses require(...) inside a repository whose root package.json declares "type": "module". In that environment the script fails immediately (ReferenceError: require is not defined), so the configured Pre/Post/Stop hooks cannot run. Rename this entrypoint to .cjs (and update hook commands) or convert it to ESM imports.
Useful? React with 👍 / 👎.
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const { spawnSync } = require('child_process'); | ||
| const { isHookEnabled } = require('../lib/hook-flags'); |
There was a problem hiding this comment.
The script imports ../lib/hook-flags, but this commit does not add any hook-flags module under .claude/scripts/lib. In a CommonJS runtime this causes MODULE_NOT_FOUND, which breaks hook enable/disable checks and prevents this runner from functioning. Add the missing helper file or fix the import path to an existing module.
Useful? React with 👍 / 👎.
| exit 0 | ||
| fi | ||
|
|
||
| printf '%s' "$INPUT" | "$SCRIPT_PATH" |
There was a problem hiding this comment.
This wrapper runs the target hook as an executable ("$SCRIPT_PATH"), but the referenced skills/continuous-learning-v2/hooks/observe.sh is committed non-executable (mode 100644). As a result, the observe hook exits with code 126 (Permission denied) whenever enabled, so observation capture fails. Invoke it as bash "$SCRIPT_PATH" or commit the target script with execute permissions.
Useful? React with 👍 / 👎.
- Remove hooks.json: all entries depend on CLAUDE_PLUGIN_ROOT env var which doesn't exist in normal checkouts - Remove scripts/hooks/: all files use CommonJS require() but project declares "type": "module", causing ReferenceError on execution. Additionally, 7 required lib files were never shipped - Remove scripts/lib/ and scripts/*.js: same CJS incompatibility - Remove model-route.md command: conflicts with repo model policy documented in CLAUDE.md and AGENTS.md - Remove model: frontmatter from all 17 agents: let repo policy decide - Remove 15 commands dependent on plugin runtime or removed scripts - Remove continuous-learning-v2 and dmux-workflows skills: depend on CLAUDE_PLUGIN_ROOT and removed script infrastructure 91 self-contained files remain (agents, commands, rules, skills).
1 participant
Summary
rules/python/directory (coding-style, patterns, security, testing)frontend-patterns,frontend-slides,python-patterns,python-testing,e2e-testingWhat's Included
ECC Analysis
Why Now
This PR prepares the codebase for the MultiplAI v2 upgrade (Subscription Pool Orchestration System). Having ECC properly configured ensures:
Test plan
.claude/directory structure is correct/verifycommand to test quality gateCLAUDE.mdandAGENTS.md