Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de35ee7aad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # ------------------------- | ||
|
|
||
| # 1 pane (focus mode) | ||
| bind-key 1 run-shell "tmux kill-pane -a" |
There was a problem hiding this comment.
Avoid shelling out to plain tmux in layout bindings
These presets run via run-shell and then invoke tmux by name, which fails when the server was started from a non-PATH binary (for example the vendored ./tools/.../tmux path) or on hosts without a global tmux install; in that setup the command returns 127 and the layout shortcut does nothing. Prefer native tmux command chaining for these bindings (or otherwise avoid relying on PATH resolution for tmux) so the presets work with the same binary that started the session.
Useful? React with 👍 / 👎.
Motivation
Description
.tmux.confthat defines layout presets bound toprefix + 1/2/3/4/6/8, a zoom toggle onprefix + 9, and a grid auto-arrange helper onprefix + g.whileloop insiderun-shellfor better portability in/bin/shcontexts.tmux select-layoutvariants (even-horizontal,tiled) to normalize final pane arrangements.Testing
./tools/linux_x86_64/tmux/3.5a/tmux -V, which returned a valid version string../tools/linux_x86_64/tmux/3.5a/tmux -f .tmux.conf -L nvimprokit-test start-server \; source-file .tmux.conf \; kill-server, which completed without errors.Codex Task