Add resume functionality and better logging#5
Open
smcguire-cmu wants to merge 19 commits intomainfrom
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 37.11% 36.17% -0.94%
==========================================
Files 14 15 +1
Lines 741 868 +127
==========================================
+ Hits 275 314 +39
- Misses 466 554 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
camposandro
reviewed
May 1, 2026
| del table | ||
| pq.write_table(arrow_table, file_path.path) | ||
| del arrow_table | ||
| pa.default_memory_pool().release_unused() |
Collaborator
There was a problem hiding this comment.
Can we add a comment here on why this is needed, for future reference?
| existing = set(pq.read_schema(file_path).names) | ||
| if flux_col_prefixes and not all(f"{p}Mag" in existing for p in flux_col_prefixes): | ||
| return False | ||
| return not (add_mjds and "midpointMjdTai" not in existing) |
Collaborator
There was a problem hiding this comment.
Can we also check if we can skip the step where we can cast to float32?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a logging module which uses python's logging module to write all pipeline outputs to both stdout and a log file which is configurable by CLI arguments. Updates all logs in the pipeline to use python logging instead of print/typer
Adds resume functionality throughout the pipeline, with each stage touching a completed file and skipping each completed stage.
Also adds individual resuming behavior for post-process and nesting, checking for already completed work, and improves the resume functionality in import stage, and makes sure that all stages are resumable.