Skip to content

Fix syntax problem in smoke test config#9

Merged
delucchi-cmu merged 1 commit intomainfrom
delucchi/smoke
May 4, 2026
Merged

Fix syntax problem in smoke test config#9
delucchi-cmu merged 1 commit intomainfrom
delucchi/smoke

Conversation

@delucchi-cmu
Copy link
Copy Markdown
Contributor

Change Description

Smoke tests currently failing, as the workflow tries to send an email that doesn't need to get sent. If the email really DID need to get sent, this would fail, too, but this should at least show green on upcoming changes to the LSDB Workflow dashboard.

See lincc-frameworks/lf-workflow-dash#93

Solution Description

Code Quality

  • I have read the Contribution Guide and agree to the Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@delucchi-cmu delucchi-cmu requested a review from smcguire-cmu May 4, 2026 19:53
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.11%. Comparing base (caf1464) to head (472b294).

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   37.11%   37.11%           
=======================================
  Files          14       14           
  Lines         741      741           
=======================================
  Hits          275      275           
  Misses        466      466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@delucchi-cmu delucchi-cmu merged commit 04540a5 into main May 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants