-
Notifications
You must be signed in to change notification settings - Fork 22
Run CI tests in Intel SDE with all feature levels #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadaptive
requested changes
Feb 5, 2026
Contributor
valadaptive
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea; just a few minor nitpicks.
Co-authored-by: valadaptive <79560998+valadaptive@users.noreply.github.com>
Contributor
Author
|
All review comments have been resolved, is this good to go? |
valadaptive
approved these changes
Feb 6, 2026
This was referenced Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs tests in Intel Software Development Emulator, like
stdarchdoes already, to verify we don't accidentally use an AVX2 instruction on SSE4.2 level or some such.Part of #124
Some NEON instructions are only available on some cores, and have to checked for at runtime via CPU features, but this PR fully covers the x86 side of things: SSE2 (baseline), SSE4.2, AVX2, AVX-512.
Intel SDE is also the only way to test AVX-512 intrinsics on Github Actions hosted runners, so we'll need it for testing AVX-512 when that arrives. We could have used QEMU for the rest, but QEMU does not support AVX-512.