vello_common: Part One of the strip rendering regression fix (relax min semantics)#1463
Merged
tomcur merged 1 commit intolinebender:mainfrom Feb 21, 2026
Merged
Conversation
Part One of fixing the performance regression caused by bumping to `fearless_simd` 0.4 in linebender#1462. I have a Part 2 that completely fixes the regression, but that probably requires more discussion, whereas the changes here will probably be uncontroversial. Relative to `main` before bumping `fearless_simd`, this now benches as as follows on my x86 machine (i7-13700k). ``` render_strips/Ghostscript_Tiger_simd time: [214.62 µs 214.97 µs 215.34 µs] change: [+10.312% +10.793% +11.168%] (p = 0.00 < 0.05) Performance has regressed. Found 1 outliers among 50 measurements (2.00%) 1 (2.00%) high mild render_strips/paris-30k_simd time: [24.577 ms 24.668 ms 24.763 ms] change: [+4.6786% +5.7653% +6.7171%] (p = 0.00 < 0.05) Performance has regressed. ```
c7e02ce to
b2c6f83
Compare
LaurenzV
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part One relaxes
f32x4::min_precisetof32x4::min, fixing part of the regression caused by bumping tofearless_simd0.4 in #1462.I have a Part 2 that completely fixes the regression, but that probably requires more discussion, whereas the changes here will probably be uncontroversial.
Relative to
mainbefore bumpingfearless_simd, this now benches as as follows on my x86 machine (i7-13700k).