Skip to content

Comments

vello_common: Part One of the strip rendering regression fix (relax min semantics)#1463

Merged
tomcur merged 1 commit intolinebender:mainfrom
tomcur:push-ypvxsqyovnyt
Feb 21, 2026
Merged

vello_common: Part One of the strip rendering regression fix (relax min semantics)#1463
tomcur merged 1 commit intolinebender:mainfrom
tomcur:push-ypvxsqyovnyt

Conversation

@tomcur
Copy link
Member

@tomcur tomcur commented Feb 20, 2026

Part One relaxes f32x4::min_precise to f32x4::min, fixing part of the regression caused by bumping to fearless_simd 0.4 in #1462.

I have a Part 2 that completely fixes the regression, but that probably requires more discussion, whereas the changes here will probably be uncontroversial.

Relative to main before bumping fearless_simd, this now benches as as follows on my x86 machine (i7-13700k).

render_strips/Ghostscript_Tiger_simd
                        time:   [214.62 µs 214.97 µs 215.34 µs]
                        change: [+10.312% +10.793% +11.168%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 50 measurements (2.00%)
  1 (2.00%) high mild
render_strips/paris-30k_simd
                        time:   [24.577 ms 24.668 ms 24.763 ms]
                        change: [+4.6786% +5.7653% +6.7171%] (p = 0.00 < 0.05)
                        Performance has regressed.

Part One of fixing the performance regression caused by bumping to
`fearless_simd` 0.4 in linebender#1462.

I have a Part 2 that completely fixes the regression, but that probably
requires more discussion, whereas the changes here will probably be
uncontroversial.

Relative to `main` before bumping `fearless_simd`, this now benches as
as follows on my x86 machine (i7-13700k).

```
render_strips/Ghostscript_Tiger_simd
                        time:   [214.62 µs 214.97 µs 215.34 µs]
                        change: [+10.312% +10.793% +11.168%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 50 measurements (2.00%)
  1 (2.00%) high mild
render_strips/paris-30k_simd
                        time:   [24.577 ms 24.668 ms 24.763 ms]
                        change: [+4.6786% +5.7653% +6.7171%] (p = 0.00 < 0.05)
                        Performance has regressed.
```
@tomcur tomcur added this pull request to the merge queue Feb 21, 2026
Merged via the queue into linebender:main with commit ab58009 Feb 21, 2026
17 checks passed
@tomcur tomcur deleted the push-ypvxsqyovnyt branch February 21, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants