Fix edge cases with unknown IP address

[yuekui]

For some reason, HTTP_X_FORWARDED_FOR might be set as "unknown, 128.1.1.9", we should be able to parse and use the closest valid value.

Summary by Sourcery

This pull request addresses an edge case in IP address parsing where the HTTP_X_FORWARDED_FOR header might contain 'unknown'. The code now correctly parses and uses the closest valid IP address. Additionally, a test has been added to ensure this functionality works as expected.

• Bug Fixes:
  • Fixed edge case where HTTP_X_FORWARDED_FOR header contains 'unknown' by parsing and using the closest valid IP address.
• Tests:
  • Added test to verify correct IP address is logged when HTTP_X_FORWARDED_FOR contains 'unknown'.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses the issue where HTTP_X_FORWARDED_FOR might contain 'unknown' followed by a valid IP address. The _get_ip_address method in rest_framework_tracking/base_mixins.py was updated to parse and use the closest valid IP address. Additionally, a new test case was added to tests/test_mixins.py to ensure the new logic works as expected.

File-Level Changes

Files	Changes
rest_framework_tracking/base_mixins.py tests/test_mixins.py	Enhanced IP address extraction logic to handle edge cases with 'unknown' values and added corresponding test cases.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @yuekui - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 4 issues found
• 🟢 Security: all looks good
• 🟡 Testing: 1 issue found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion (performance): Combining lists directly can be inefficient.

Using the += operator to combine lists can be less efficient than using extend(), especially for large lists. Consider using raw_possibles.extend(request.META.get("REMOTE_ADDR", "").split(",")) for better performance.

Suggested change

	raw_possibles = request.META.get("HTTP_X_FORWARDED_FOR", "").split(",")
	raw_possibles += request.META.get("REMOTE_ADDR", "").split(",")
	raw_possibles = request.META.get("HTTP_X_FORWARDED_FOR", "").split(",")
	raw_possibles.extend(request.META.get("REMOTE_ADDR", "").split(","))

[sourcery-ai]

issue (bug_risk): Returning the first element of raw_possibles may not be reliable.

If raw_possibles is empty, this line will raise an IndexError. Consider adding a check to ensure raw_possibles is not empty before attempting to access its first element.