Skip to content

Add negative int32 test coverage for Avro wire format and type widening #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leiykpt merged 1 commit into from
Mar 27, 2026
Merged

Add negative int32 test coverage for Avro wire format and type widening #602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions ...o/src/test/java/com/linkedin/avroutil1/compatibility/AvroWireFormatCompatibilityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,4 +154,65 @@ public void demonstrateTypeWideningWithinUnionField() throws Exception {
AvroCodecUtil.deserializeAsGeneric(bytes, writerSchema, readerSchemaWithLong);
Assert.assertEquals(deserializedGenericRecord.get(0), 1L);
}

@Test
public void testNegativeInt32BinaryRoundtrip() throws Exception {
Schema schema = AvroCompatibilityHelper.parse(TestUtil.load("allavro/RecordWithNumericFields.avsc"));
int[] negativeValues = {-1, -100, Integer.MIN_VALUE};

for (int negativeValue : negativeValues) {
GenericData.Record record = new GenericData.Record(schema);
record.put("intField", negativeValue);
record.put("longField", 0L);
record.put("floatField", 0.0f);
record.put("doubleField", 0.0d);

byte[] bytes = AvroCodecUtil.serializeBinary(record);
GenericRecord deserialized = AvroCodecUtil.deserializeAsGeneric(bytes, schema, schema);

Assert.assertEquals(deserialized.get(schema.getField("intField").pos()), negativeValue,
"Negative int32 value " + negativeValue + " should survive binary roundtrip");
}
}

@Test
public void testNegativeInt32JsonRoundtrip() throws Exception {
Schema schema = AvroCompatibilityHelper.parse(TestUtil.load("allavro/RecordWithNumericFields.avsc"));
int[] negativeValues = {-1, -100, Integer.MIN_VALUE};

for (int negativeValue : negativeValues) {
GenericData.Record record = new GenericData.Record(schema);
record.put("intField", negativeValue);
record.put("longField", 0L);
record.put("floatField", 0.0f);
record.put("doubleField", 0.0d);

String json = AvroCodecUtil.serializeJson(record, AvroCompatibilityHelper.getRuntimeAvroVersion());
Decoder jsonDecoder = AvroCompatibilityHelper.newCompatibleJsonDecoder(schema, json);
GenericDatumReader<IndexedRecord> reader = new GenericDatumReader<>(schema);
IndexedRecord deserialized = reader.read(null, jsonDecoder);

Assert.assertEquals(deserialized.get(schema.getField("intField").pos()), negativeValue,
"Negative int32 value " + negativeValue + " should survive JSON roundtrip");
}
}

@Test
public void testNegativeInt32TypeWideningToLong() throws Exception {
Schema writerSchema =
AvroCompatibilityHelper.parse(TestUtil.load("allavro/WidenIntToLongInUnionField_writer.avsc"));
Schema readerSchema =
AvroCompatibilityHelper.parse(TestUtil.load("allavro/WidenIntToLongInUnionField_reader.avsc"));
int[] negativeValues = {-1, -100, Integer.MIN_VALUE};

for (int negativeValue : negativeValues) {
GenericData.Record record = new GenericData.Record(writerSchema);
record.put("f1", negativeValue);
byte[] bytes = AvroCodecUtil.serializeBinary(record);

GenericRecord deserialized = AvroCodecUtil.deserializeAsGeneric(bytes, writerSchema, readerSchema);
Assert.assertEquals(deserialized.get(0), (long) negativeValue,
"Negative int32 value " + negativeValue + " should widen to long correctly");
}
}
}
Loading