Re-revert #610: restore HTS fields in table list api (#579)#629
Closed
jiang95-dev wants to merge 1 commit into
Closed
Re-revert #610: restore HTS fields in table list api (#579)#629jiang95-dev wants to merge 1 commit into
jiang95-dev wants to merge 1 commit into
Conversation
…n#579) This reverts commit 8b06479 (linkedin#610), which had reverted linkedin#579 ("Support returning HTS fields in table list api"). This change re-applies the linkedin#579 additions. ## Changes - [X] Client-facing API Changes - [ ] Internal API Changes - [ ] Bug Fixes - [ ] New Features - [ ] Performance Improvements - [ ] Code Style - [X] Refactoring - [X] Tests Restores the public list-table API additions and supporting tests from linkedin#579.
Collaborator
Author
|
Superseded by #630, which uses a branch in the openhouse repo instead of a fork. |
jiang95-dev
deleted the
lejiang/re-revert-610-restore-hts-fields-table-list
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-reverts #610, which had reverted #579 ("Support returning HTS fields in table list api"). This restores the #579 additions: the public list-table API support for returning HouseTable (HTS) fields.
This is a clean
git revertof the #610 squash commit (8b06479) with no merge conflicts — the #589findHouseTabledrop-path code that originally conflicted is untouched.Changes
Restores the public list-table API additions and supporting tests from #579 across the tables service (handler, validator, controller, mapper, repository, service layers) and the
listHouseTablescatalog method.Testing Done
Restores the original #579 tests (
TablesControllerTest,TablesServiceTest) verbatim../gradlew spotlessCheckpasses (JDK 17). Since this is a pure revert-of-revert restoring previously-merged, previously-tested code, no new test logic was introduced.Additional Information