Filter all-modules aggregate to only published modules#637
Merged
Conversation
The all-modules aggregate referenced every leaf module, including client/common — a codegen-only helper consumed at build time via `apply from:` that is never published to Maven. ELR reads the all-modules POM and walks its dependencies transitively to mirror artifacts into the internal artifactory, so referencing an unpublished coordinate breaks the mirror (and collides on artifactId `common` with the published services/common). Restrict the aggregate to leaf modules that apply maven-publish, so the published POM lists only resolvable coordinates. The member list now tracks publish status automatically: a module that stops publishing drops out of the POM with no manual upkeep. Kept as a real-dependency aggregate, not a BOM — ELR walks <dependencies>, and a BOM's lazy <dependencyManagement> would leave nothing to mirror.
jiang95-dev
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
all-modulesaggregate referenced every leaf module, includingclient/common— a codegen-only helper consumed at build time viaapply from:that is never published to Maven. ELR reads theall-modulesPOM and walks its<dependencies>transitively to mirror artifacts into the internal artifactory, so referencing an unpublished coordinate breaks the mirror (and collides on artifactIdcommonwith the publishedservices/common).This restricts the aggregate to leaf modules that apply
maven-publish, so the published POM lists only resolvable coordinates. The member list now tracks publish status automatically — a module that stops publishing drops out of the POM with no manual upkeep.Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
all-modules/build.gradlenow evaluates each leaf module and includes it only if it appliesmaven-publish:Kept as a real-dependency aggregate, not a BOM: ELR walks
<dependencies>, and a BOM publishes only lazy<dependencyManagement>constraints, which would leave nothing to mirror.Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Build-config change, verified by generating and inspecting the published POM locally:
implementationdependencies; the single unpublished leaf (client/common) is absent.maven-publishfromapps/optimizer/analyzerapp, regenerated the POM →analyzerappdropped out (35 → 34) while the still-publishedanalyzerlibrary it wraps stayed in. Reverted.Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.
No breaking changes — downstream ELR consumers continue to depend on the single
all-modulescoordinate.