Point strings.csv at the screens contributors can actually see - #2
Merged
Conversation
51 rows still said "Admin" after the admin-only labels were pruned. Every one was a shared string customers DO see — 'Uptime' on the dashboard and the monthly SLA email, 'Post' on incidents/show — so the column was telling translators to treat customer-facing words as operator chrome. 23 of them have one clear customer area and now name it. The other 28 are generic UI words spanning the whole app; forcing a single screen on those picks one at random, which is how a first pass had 'Dashboard' come out as "Checkout" and 'Show' as "Developers (API docs)". Those read "Shared UI label", which is both true and the thing a translator needs to know: keep it short and generic, it lands in a dozen places. Also strips admin paths out of 73 Screen / file lists, and drops 'Reviews' (943 strings). reviews/admin and reviews/admin-edit are admin screens that live outside resources/views/admin/, so the first pass missed them — the locale pin already covered them, the analysis did not. Every remaining "admin" in the file is prose about the reader's OWN forum admin panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin-only labels were pruned earlier, but
context/strings.csvstill labelled 51 rows "Admin" — and every one of them is a shared string that customers do see (Uptimeon the dashboard and the monthly SLA email,Postonincidents/show). The column was telling translators to treat customer-facing words as operator chrome.New,Actions,View,Delete). Forcing a single screen on those picks one at random — a first pass hadDashboardcome out as Checkout andShowas Developers (API docs). They now read Shared UI label, which is what a translator actually needs: keep it short and generic, it lands in a dozen places.Screen / filelists had admin paths stripped out.Reviewsdropped (943 strings).reviews/adminandreviews/admin-editare admin screens living outsideresources/views/admin/, so the earlier analysis missed them. The locale pin already covered them; the analysis did not.Every remaining "admin" in the file is prose about the reader's own forum admin panel.
Validator passes 9/9.