Skip to content

Using enzyme-to-json to get better diff snapshots #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patw0929 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Using enzyme-to-json to get better diff snapshots #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1f9acc
Install enzyme-to-json
patw0929 Nov 14, 2017
c8af405
Using enzyme-to-json to get better diff snapshots
patw0929 Nov 14, 2017
9cb7fa5
Updated snapshots
patw0929 Nov 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"babel-preset-react": "^6.24.1",
"babel-preset-stage-0": "^6.24.1",
"enzyme": "^2.9.1",
"enzyme-to-json": "^2.0.1",
"jest": "^20.0.4",
"nock": "^9.0.14",
"react-test-renderer": "^15.6.1"
Expand Down
13 changes: 7 additions & 6 deletions src/components/__tests__/A.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import React, { Component } from 'react';
import { render, shallow, mount } from 'enzyme';
import toJson from 'enzyme-to-json';

describe('<A />', () => {
let makeSubject;
Expand All @@ -22,25 +23,25 @@ describe('<A />', () => {
makeShallowSubject = () => shallow(<A {...params} />)
makeRenderSubject = () => render(<A {...params} />);
});

describe('snapshots', () => {
// snapshot
it('should match latest render snapshot', () => {
const subject = makeRenderSubject();

expect(subject.html()).toMatchSnapshot();
expect(toJson(subject)).toMatchSnapshot();
});

it('should match latest shallow snapshot', () => {
const subject = makeShallowSubject();

expect(subject.html()).toMatchSnapshot();
expect(toJson(subject)).toMatchSnapshot();
});

it('should match latest mount snapshot', () => {
const subject = makeSubject();

expect(subject.html()).toMatchSnapshot();
expect(toJson(subject)).toMatchSnapshot();
});
});

Expand All @@ -54,15 +55,15 @@ describe('<A />', () => {
// event simulate with shallow
it('should call foo when .btn-foo clicked', () => {
const subject = makeShallowSubject();

subject.find('.btn-bar').simulate('click');
expect(params.bar).toHaveBeenCalled();
});

// event simulate with mount
it('should call foo when .btn-foo clicked', () => {
const subject = makeSubject();

subject.instance().foo = jest.fn();
subject.update();
subject.find('.btn-foo').simulate('click');
Expand Down
7 changes: 4 additions & 3 deletions src/components/__tests__/B.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';
import { shallow, mount } from 'enzyme';
import toJson from 'enzyme-to-json';

describe('<B />', () => {
let B;
Expand All @@ -16,12 +17,12 @@ describe('<B />', () => {
it('should match shallow snapshot', () => {
const subject = makeShallowSubject();

expect(subject.html()).toMatchSnapshot();
expect(toJson(subject)).toMatchSnapshot();
});

it('should match snapshot', () => {
const subject = makeSubject();

expect(subject.html()).toMatchSnapshot();
expect(toJson(subject)).toMatchSnapshot();
});
});
});
2 changes: 1 addition & 1 deletion src/components/__tests__/C.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ describe('<C />', () => {

expect(subject).toMatchSnapshot();
});
});
});
134 changes: 131 additions & 3 deletions src/components/__tests__/__snapshots__/A.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,135 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`<A /> snapshots should match latest mount snapshot 1`] = `"<div><h1 style=\\"display: none;\\">title</h1><button class=\\"btn-foo\\">click me</button><button class=\\"btn-bar\\">click me</button><nav><a href=\\"#\\"><!-- react-text: 7 -->I am link <!-- /react-text --><!-- react-text: 8 -->0<!-- /react-text --><!-- react-text: 9 -->.<!-- /react-text --></a><a href=\\"#\\"><!-- react-text: 11 -->I am link <!-- /react-text --><!-- react-text: 12 -->1<!-- /react-text --><!-- react-text: 13 -->.<!-- /react-text --></a><a href=\\"#\\"><!-- react-text: 15 -->I am link <!-- /react-text --><!-- react-text: 16 -->2<!-- /react-text --><!-- react-text: 17 -->.<!-- /react-text --></a></nav></div>"`;
exports[`<A /> snapshots should match latest mount snapshot 1`] = `
<A
bar={[Function]}
>
<div>
<h1
style={
Object {
"display": "none",
}
}
>
title
</h1>
<button
className="btn-foo"
onClick={[Function]}
>
click me
</button>
<button
className="btn-bar"
onClick={[Function]}
>
click me
</button>
<B>
<nav>
<C
id={0}
key="0"
>
<a
href="#"
>
I am link
0
.
</a>
</C>
<C
id={1}
key="1"
>
<a
href="#"
>
I am link
1
.
</a>
</C>
<C
id={2}
key="2"
>
<a
href="#"
>
I am link
2
.
</a>
</C>
</nav>
</B>
</div>
</A>
`;

exports[`<A /> snapshots should match latest render snapshot 1`] = `"<div><h1 style=\\"display:none;\\">title</h1><button class=\\"btn-foo\\">click me</button><button class=\\"btn-bar\\">click me</button><nav><a href=\\"#\\">I am link 0.</a><a href=\\"#\\">I am link 1.</a><a href=\\"#\\">I am link 2.</a></nav></div>"`;
exports[`<A /> snapshots should match latest render snapshot 1`] = `
<div>
<h1
style="display:none;"
>
title
</h1>
<button
class="btn-foo"
>
click me
</button>
<button
class="btn-bar"
>
click me
</button>
<nav>
<a
href="#"
>
I am link 0.
</a>
<a
href="#"
>
I am link 1.
</a>
<a
href="#"
>
I am link 2.
</a>
</nav>
</div>
`;

exports[`<A /> snapshots should match latest shallow snapshot 1`] = `"<div><h1 style=\\"display:none;\\">title</h1><button class=\\"btn-foo\\">click me</button><button class=\\"btn-bar\\">click me</button><nav><a href=\\"#\\">I am link 0.</a><a href=\\"#\\">I am link 1.</a><a href=\\"#\\">I am link 2.</a></nav></div>"`;
exports[`<A /> snapshots should match latest shallow snapshot 1`] = `
<div>
<h1
style={
Object {
"display": "none",
}
}
>
title
</h1>
<button
className="btn-foo"
onClick={[Function]}
>
click me
</button>
<button
className="btn-bar"
onClick={[Function]}
>
click me
</button>
<B />
</div>
`;
60 changes: 58 additions & 2 deletions src/components/__tests__/__snapshots__/B.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,61 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`<B /> should match shallow snapshot 1`] = `"<nav><a href=\\"#\\">I am link 0.</a><a href=\\"#\\">I am link 1.</a><a href=\\"#\\">I am link 2.</a></nav>"`;
exports[`<B /> should match shallow snapshot 1`] = `
<nav>
<C
id={0}
key="0"
/>
<C
id={1}
key="1"
/>
<C
id={2}
key="2"
/>
</nav>
`;

exports[`<B /> should match snapshot 1`] = `"<nav><a href=\\"#\\"><!-- react-text: 3 -->I am link <!-- /react-text --><!-- react-text: 4 -->0<!-- /react-text --><!-- react-text: 5 -->.<!-- /react-text --></a><a href=\\"#\\"><!-- react-text: 7 -->I am link <!-- /react-text --><!-- react-text: 8 -->1<!-- /react-text --><!-- react-text: 9 -->.<!-- /react-text --></a><a href=\\"#\\"><!-- react-text: 11 -->I am link <!-- /react-text --><!-- react-text: 12 -->2<!-- /react-text --><!-- react-text: 13 -->.<!-- /react-text --></a></nav>"`;
exports[`<B /> should match snapshot 1`] = `
<B>
<nav>
<C
id={0}
key="0"
>
<a
href="#"
>
I am link
0
.
</a>
</C>
<C
id={1}
key="1"
>
<a
href="#"
>
I am link
1
.
</a>
</C>
<C
id={2}
key="2"
>
<a
href="#"
>
I am link
2
.
</a>
</C>
</nav>
</B>
`;
34 changes: 33 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,6 +1261,18 @@ entities@^1.1.1, entities@~1.1.1:
version "1.1.1"
resolved "https://registry.yarnpkg.com/entities/-/entities-1.1.1.tgz#6e5c2d0a5621b5dadaecef80b90edfb5cd7772f0"

enzyme-to-json@^2.0.1:
version "2.0.1"
resolved "https://registry.yarnpkg.com/enzyme-to-json/-/enzyme-to-json-2.0.1.tgz#e8b223040a7cc603bc678a4698c1a83c8c649932"
dependencies:
lodash.filter "^4.6.0"
lodash.isnil "^4.0.0"
lodash.isplainobject "^4.0.6"
lodash.omitby "^4.6.0"
lodash.range "^3.2.0"
object-values "^1.0.0"
object.entries "^1.0.4"

enzyme@^2.9.1:
version "2.9.1"
resolved "https://registry.yarnpkg.com/enzyme/-/enzyme-2.9.1.tgz#07d5ce691241240fb817bf2c4b18d6e530240df6"
Expand Down Expand Up @@ -2244,7 +2256,7 @@ lodash.defaults@^4.0.1:
version "4.2.0"
resolved "https://registry.yarnpkg.com/lodash.defaults/-/lodash.defaults-4.2.0.tgz#d09178716ffea4dde9e5fb7b37f6f0802274580c"

lodash.filter@^4.4.0:
lodash.filter@^4.4.0, lodash.filter@^4.6.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash.filter/-/lodash.filter-4.6.0.tgz#668b1d4981603ae1cc5a6fa760143e480b4c4ace"

Expand All @@ -2256,6 +2268,14 @@ lodash.foreach@^4.3.0:
version "4.5.0"
resolved "https://registry.yarnpkg.com/lodash.foreach/-/lodash.foreach-4.5.0.tgz#1a6a35eace401280c7f06dddec35165ab27e3e53"

lodash.isnil@^4.0.0:
version "4.0.0"
resolved "https://registry.yarnpkg.com/lodash.isnil/-/lodash.isnil-4.0.0.tgz#49e28cd559013458c814c5479d3c663a21bfaa6c"

lodash.isplainobject@^4.0.6:
version "4.0.6"
resolved "https://registry.yarnpkg.com/lodash.isplainobject/-/lodash.isplainobject-4.0.6.tgz#7c526a52d89b45c45cc690b88163be0497f550cb"

lodash.map@^4.4.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash.map/-/lodash.map-4.6.0.tgz#771ec7839e3473d9c4cde28b19394c3562f4f6d3"
Expand All @@ -2264,10 +2284,18 @@ lodash.merge@^4.4.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash.merge/-/lodash.merge-4.6.0.tgz#69884ba144ac33fe699737a6086deffadd0f89c5"

lodash.omitby@^4.6.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash.omitby/-/lodash.omitby-4.6.0.tgz#5c15ff4754ad555016b53c041311e8f079204791"

lodash.pick@^4.2.1:
version "4.4.0"
resolved "https://registry.yarnpkg.com/lodash.pick/-/lodash.pick-4.4.0.tgz#52f05610fff9ded422611441ed1fc123a03001b3"

lodash.range@^3.2.0:
version "3.2.0"
resolved "https://registry.yarnpkg.com/lodash.range/-/lodash.range-3.2.0.tgz#f461e588f66683f7eadeade513e38a69a565a15d"

lodash.reduce@^4.4.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash.reduce/-/lodash.reduce-4.6.0.tgz#f1ab6b839299ad48f784abbf476596f03b914d3b"
Expand Down Expand Up @@ -2477,6 +2505,10 @@ object-keys@^1.0.10, object-keys@^1.0.8:
version "1.0.11"
resolved "https://registry.yarnpkg.com/object-keys/-/object-keys-1.0.11.tgz#c54601778ad560f1142ce0e01bcca8b56d13426d"

object-values@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/object-values/-/object-values-1.0.0.tgz#72af839630119e5b98c3b02bb8c27e3237158105"

object.assign@^4.0.4:
version "4.0.4"
resolved "https://registry.yarnpkg.com/object.assign/-/object.assign-4.0.4.tgz#b1c9cc044ef1b9fe63606fc141abbb32e14730cc"
Expand Down