Skip to content

fix: push on initial install and encode credentials #3395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
merll wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −5
Open

fix: push on initial install and encode credentials #3395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9403a6
fix: on initial install attempt to push also without commit
merll Jun 26, 2026
5b5b091
fix: make sure to encode credentials separately
merll Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/cmd/commit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,12 @@ const commitAndPush = async (gitConfig: GitRepoConfig, initialInstall = false):
const filesChangedCount = statusOutput.split('\n').length - 1
if (filesChangedCount === 0) {
d.log('Nothing to commit')
return
if (!initialInstall) {
return
}
} else {
await $git`git commit -m ${message} --no-verify`.quiet()
}
await $git`git commit -m ${message} --no-verify`.quiet()
} catch (e) {
const errorMsg = `commitAndPush error: ${e?.message?.replace(password, '****')}`
d.error(errorMsg)
Expand Down
6 changes: 3 additions & 3 deletions src/common/git-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ export function getAuthUrlFromGitConfig(credentials: Partial<GitConfigData>): st
}
const url = new URL(repoUrl)
if (username) {
url.username = username
url.password = password
url.username = encodeURIComponent(username)
url.password = encodeURIComponent(password)
} else {
url.username = password
url.username = encodeURIComponent(password)
url.password = ''
}
return url.toString()
Expand Down
Loading