Remove standalone lintel-github-action build and release#98
Open
Remove standalone lintel-github-action build and release#98
Conversation
…mand Move the github-action functionality into the main lintel binary as a hidden `lintel github-action` subcommand. The crate now exports a bpaf struct (GithubActionArgs) and async runner instead of being a standalone binary. Key changes: - Switch from lintel-validate to lintel-check (adds format checking) - Add FormatDiagnostic::file_path() accessor in lintel-format - Remove tokio dependency (runtime provided by caller) - Update README to reflect new architecture
Now that lintel-github-action is a library subcommand (`lintel github-action`), remove its separate build matrix entry, release workflow, release-plz trigger, and nix packages. Skip its release and publish in release-plz.
…tibility Move x86_64 and aarch64 GNU Linux builds from nix to cargo with Debian Buster slim containers to ensure broad glibc compatibility. Add smoke tests, glibc verification steps, and proper tar.gz packaging for non-Windows targets.
Switch GNU Linux containers from debian:buster-slim to rust:bullseye for Debian 11 glibc compatibility. Add RUSTFLAGS for symbol stripping and single codegen unit in CI. Remove manual build dependency install since rust:bullseye includes the toolchain.
- Move aarch64-apple-darwin and x86_64-apple-darwin from nix builds to cargo builds, avoiding non-portable nix store dylib references - Add pull_request trigger for build workflow file changes so CI can be tested on branches before merging - Nix builds now only handle musl static linking for Linux
Update version tags (vX.Y.Z and vX) on lintel-rs/action when releasing lintel, so the GitHub Action tracks the latest release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-lintel-github-action.ymlworkflowACTION_TAGtrigger block fromrelease-plz.ymllintel-github-action-staticmusl build frombuild.ymlmatrixrelease = false,publish = false)lintel-github-actionandlintel-github-action-staticfrom nix packages and flake checksNow that
lintel-github-actionis a library crate andlintelprovides it aslintel github-action, it no longer needs its own build/release pipeline.Test plan
nix flake checkpassesnix build .#allsucceeds without lintel-github-action