Skip to content

[PW_SID:1060502] net: spacemit: A few minor/theoretical fixes#1540

Closed
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw1060502
Closed

[PW_SID:1060502] net: spacemit: A few minor/theoretical fixes#1540
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw1060502

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Mar 3, 2026

PR for series 1060502 applied to workflow__riscv__fixes

Name: net: spacemit: A few minor/theoretical fixes
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1060502
Version: 1

@dramforever
net: spacemit: Remove unused buff_addr fields
b260447 
These were never used. Just remove them.

Fixes: bfec6d7 ("net: spacemit: Add K1 Ethernet MAC")
Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@dramforever
net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()
1d4937f 
Even if we get a dma_mapping_error() while mapping an RX buffer, we
should still update rx_ring->head to ensure that the buffers we were
able to allocate and map are used. Fix this by breaking out to the
existing code after the loop, analogous to the existing handling for skb
allocation failure.

Fixes: bfec6d7 ("net: spacemit: Add K1 Ethernet MAC")
Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@dramforever
net: spacemit: Fix error handling in emac_tx_mem_map()
53d6179 
The DMA mappings were leaked on mapping error. Free them with the
existing emac_free_tx_buf() function.

Fixes: bfec6d7 ("net: spacemit: Add K1 Ethernet MAC")
Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@dramforever
net: spacemit: Free rings of memory after unmapping DMA
fc01e60 
In emac_free_{tx,rx}_resources, call dma_free_coherent() to unmap DMA
before calling kfree() to deallocate the memory, instead of the other
way around.

Fixes: bfec6d7 ("net: spacemit: Add K1 Ethernet MAC")
Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.53 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1022.40 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1379.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.58 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.18 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 84.76 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[net-next,1/4] net: spacemit: Remove unused buff_addr fields"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 136.68 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1020.49 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1379.52 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.59 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.09 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.06 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.82 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
kdoc
Desc: Detects for kdoc errors
Duration: 0.92 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 2: "[net-next,2/4] net: spacemit: Fix error handling in emac_alloc_rx_desc_buffers()"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 141.17 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1026.82 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1380.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.79 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.74 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.55 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
module-param
Desc: Detect module_param changes
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 3: "[net-next,3/4] net: spacemit: Fix error handling in emac_tx_mem_map()"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 135.57 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1022.33 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1384.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.68 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.83 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 84.75 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
module-param
Desc: Detect module_param changes
Duration: 4.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.64 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 4: "[net-next,4/4] net: spacemit: Free rings of memory after unmapping DMA"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1060502 branch March 11, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @dramforever