Skip to content

[PW_SID:1060568] [v1] firmware: microchip: fail auto-update probe if no flash found#1541

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1060568
Closed

[PW_SID:1060568] [v1] firmware: microchip: fail auto-update probe if no flash found#1541
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1060568

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Mar 3, 2026

PR for series 1060568 applied to workflow__riscv__fixes

Name: [v1] firmware: microchip: fail auto-update probe if no flash found
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1060568
Version: 1

@ConchuOD
firmware: microchip: fail auto-update probe if no flash found
8eec9da 
There's no point letting the driver probe if there is no flash, as
trying to do a firmware upload will fail. Move the code that attempts
to get the flash from firmware upload to probe, and let it emit a
message to users stating why auto-update is not supported.
The code currently could have a problem if there's a flash in
devicetree, but the system controller driver fails to get a pointer to
it from the mtd subsystem, which will cause
mpfs_sys_controller_get_flash() to return an error. Check for errors and
null, instead of just null, in the new clause.

CC: stable@vger.kernel.org
Fixes: ec5b0f1 ("firmware: microchip: add PolarFire SoC Auto Update support")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 139.73 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1048.37 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1427.65 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 27.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.46 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.76 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
kdoc
Desc: Detects for kdoc errors
Duration: 0.97 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
module-param
Desc: Detect module_param changes
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 3, 2026

Patch 1: "[v1] firmware: microchip: fail auto-update probe if no flash found"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1060568 branch March 11, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @ConchuOD