[PW_SID:1064058] Fix get cpu steer-tag fail on ARM64 platform by linux-riscv-bot · Pull Request #1583 · linux-riscv/linux

linux-riscv-bot · 2026-03-10T03:46:45Z

PR for series 1064058 applied to workflow__riscv__fixes

Name: Fix get cpu steer-tag fail on ARM64 platform
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1064058
Version: 5

To unify the CPU ACPI ID retrieval interface across architectures, rename the existing get_acpi_id_for_cpu() function to acpi_get_cpu_acpi_id() on arm64/riscv/loongarch platforms. This is a pure rename with no functional change, preparing for a consistent ACPI Processor UID retrieval interface across all ACPI-enabled platforms. Cc: stable@vger.kernel.org Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

pcie_tph_get_cpu_st() is broken on ARM64: 1. pcie_tph_get_cpu_st() passes cpu_uid to the PCI ACPI DSM method. cpu_uid should be the ACPI Processor UID [1]. 2. In BNXT, pcie_tph_get_cpu_st() is passed a cpu_uid obtained via cpumask_first(irq->cpu_mask) - the logical CPU ID of a CPU core, generated and managed by kernel (e.g., [0,255] for a system with 256 logical CPU cores). 3. On ARM64 platforms, ACPI assigns Processor UID to cores listed in the MADT table, and this UID may not match the kernel's logical CPU ID. When this occurs, the mismatch results in the wrong CPU steer-tag. 4. On AMD x86 the logical CPU ID is identical to the ACPI Processor UID so the mismatch is not seen. Resolution: 1. Implement acpi_get_cpu_acpi_id() for x86, which replaces cpu_acpi_id(). All ACPI platforms now have an implementation. 2. Use acpi_get_cpu_acpi_id() in pcie_tph_get_cpu_st() to translate from logical CPU ID to ACPI Processor UID needed for the DSM call. 3. Rename pcie_tpu_get_cpu_st() parameter from cpu_uid to cpu to reflect that it is a logical CPU_ID. [1] According to ECN_TPH-ST_Revision_20200924 (https://members.pcisig.com/wg/PCI-SIG/document/15470), the input is defined as: "If the target is a processor, then this field represents the ACPI Processor UID of the processor as specified in the MADT. If the target is a processor container, then this field represents the ACPI Processor UID of the processor container as specified in the PPTT." Fixes: d2e8a34 ("PCI/TPH: Add Steering Tag support") Cc: stable@vger.kernel.org Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2026-03-10T03:52:49Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 136.39 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:14:43Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1311.73 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:46:37Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1913.50 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:47:06Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 27.32 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:47:37Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.94 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:47:41Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.79 seconds
Result: WARNING
Output:

WARNING: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?

total: 0 errors, 1 warnings, 0 checks, 120 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit c406d7484c81 ("ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 120 lines checked
WARNING: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?

linux-riscv-bot · 2026-03-10T04:49:06Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.74 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:49:08Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:49:10Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:49:12Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:49:13Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:49:15Z

Patch 1: "[v5,1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T04:51:49Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.84 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:10:53Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1142.85 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:38:39Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1664.81 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:39:08Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.98 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:39:37Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.01 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:39:42Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 3.22 seconds
Result: WARNING
Output:

CHECK: Consider using #include <linux/acpi.h> instead of <asm/acpi.h>
#113: FILE: arch/x86/kernel/cpu/common.c:32:
+#include <asm/acpi.h>

CHECK: Consider using #include <linux/smp.h> instead of <asm/smp.h>
#121: FILE: arch/x86/kernel/cpu/common.c:61:
+#include <asm/smp.h>

total: 0 errors, 0 warnings, 2 checks, 120 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit ded7d5505315 ("PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 2 checks, 120 lines checked
CHECK: Consider using #include <linux/acpi.h> instead of <asm/acpi.h>
CHECK: Consider using #include <linux/smp.h> instead of <asm/smp.h>

linux-riscv-bot · 2026-03-10T05:41:08Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 85.33 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:41:10Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.44 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:41:13Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:41:14Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:41:16Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

linux-riscv-bot · 2026-03-10T05:41:18Z

Patch 2: "[v5,2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

fengchengwen added 2 commits March 10, 2026 03:46

linux-riscv-bot closed this Mar 12, 2026

linux-riscv-bot deleted the pw1064058 branch March 12, 2026 08:09

Conversation

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

linux-riscv-bot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants