Skip to content

[PW_SID:1064189] riscv: patch: Avoid early page_to_phys()#1585

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1064189
Closed

[PW_SID:1064189] riscv: patch: Avoid early page_to_phys()#1585
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1064189

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Mar 10, 2026

PR for series 1064189 applied to workflow__riscv__fixes

Name: riscv: patch: Avoid early page_to_phys()
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1064189
Version: 1

@dramforever
riscv: patch: Avoid early page_to_phys()
89e9dde 
Similarly to commit 8d09e2d ("arm64: patching: avoid early
page_to_phys()"), avoid using phys_to_page() for the kernel address case
in patch_map().

Since this is called from apply_boot_alternatives() in setup_arch(), and
commit 4267739 ("arch, mm: consolidate initialization of SPARSE
memory model") has moved sparse_init() to after setup_arch(),
phys_to_page() is not available there yet, and it panics on boot with
SPARSEMEM on RV32, which does not use SPARSEMEM_VMEMMAP.

Reported-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Closes: https://lore.kernel.org/r/20260223144108-dcace0b9-02e8-4b67-a7ce-f263bed36f26@linutronix.de/
Fixes: 4267739 ("arch, mm: consolidate initialization of SPARSE memory model")
Suggested-by: Mike Rapoport <rppt@kernel.org>
Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.00 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1106.64 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1609.38 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.14 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.88 seconds
Result: WARNING
Output:

WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#52: FILE: arch/riscv/kernel/patch.c:52:
+		BUG_ON(!page);

total: 0 errors, 1 warnings, 0 checks, 30 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 89e9dde88d09 ("riscv: patch: Avoid early page_to_phys()") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 30 lines checked
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.81 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
kdoc
Desc: Detects for kdoc errors
Duration: 1.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 10, 2026

Patch 1: "riscv: patch: Avoid early page_to_phys()"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1064189 branch March 18, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @dramforever