Skip to content

[PW_SID:1065485] gpio/pinctrl: spacemit: Add GPIO pin configuration support for K1#1601

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1065485
Closed

[PW_SID:1065485] gpio/pinctrl: spacemit: Add GPIO pin configuration support for K1#1601
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw1065485

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

PR for series 1065485 applied to workflow__riscv__fixes

Name: gpio/pinctrl: spacemit: Add GPIO pin configuration support for K1
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1065485
Version: 1

Return -ENOTSUPP instead of -EINVAL when encountering unsupported pin
configuration parameters. This is more logical and allows the GPIO
subsystem to gracefully handle unsupported parameters via functions like
gpio_set_config_with_argument_optional(), which specifically ignores
-ENOTSUPP but treats others as failure.

Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Assign gpiochip_generic_config() to the set_config() callback to support
pin configuration through the GPIO subsystem. This allows users to
configure GPIO pin attributes like pull-up/down when specifying a GPIO
line in the Device Tree.

Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.50 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1104.79 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1629.46 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.84 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.48 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.70 seconds
Result: WARNING
Output:

WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#28: FILE: drivers/pinctrl/spacemit/pinctrl-k1.c:677:
+		return -ENOTSUPP;

WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#37: FILE: drivers/pinctrl/spacemit/pinctrl-k1.c:743:
+			return -ENOTSUPP;

total: 0 errors, 2 warnings, 0 checks, 52 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 11985d196cd4 ("pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 52 lines checked
WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP


@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 84.17 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 136.12 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1015.43 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1388.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 27.01 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.76 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 86.35 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
kdoc
Desc: Detects for kdoc errors
Duration: 0.85 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[2/2] gpio: spacemit-k1: Add set_config callback support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1065485 branch March 18, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants