Skip to content

[PW_SID:1066670] [v2] reset: spacemit: k3: Decouple composite reset lines#1607

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1066670
Closed

[PW_SID:1066670] [v2] reset: spacemit: k3: Decouple composite reset lines#1607
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1066670

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Mar 14, 2026

PR for series 1066670 applied to workflow__riscv__fixes

Name: [v2] reset: spacemit: k3: Decouple composite reset lines
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1066670
Version: 2

reset: spacemit: k3: Decouple composite reset lines
7621b8c 
Instead of grouping several different reset lines into one composite
reset, decouple them to individual ones which make it more aligned
with underlying hardware. And for DWC USB driver, it will match well
with the number of the reset property in the DT bindings.

The DWC3 USB host controller in K3 SoC has three reset lines - AHB, VCC,
PHY. The PCIe controller also has three reset lines - DBI, Slave, Master.
Also three reset lines each for UCIE and RCPU block.

As an agreement with maintainer, the reset IDs has been rearranged as
contiguous number and pushed as a fix for the driver, and reason is that
there isn't any consumer of reset driver so far, so should not cause
any ABI breakage. Also, the changes of DT binding header file and reset
driver are merged together as one single commit to avoid git-bisect
breakage.

Fixes: 938ce3b ("reset: spacemit: Add SpacemiT K3 reset driver)
Fixes: 216e0a5 ("dt-bindings: soc: spacemit: Add K3 reset support and IDs")
Signed-off-by: Yixun Lan <dlan@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.13 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1053.53 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1411.98 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.70 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.10 seconds
Result: WARNING
Output:

WARNING: Please use correct Fixes: style 'Fixes: <12+ chars of sha1> ("<title line>")' - ie: 'Fixes: 938ce3b16582 ("reset: spacemit: Add SpacemiT K3 reset driver")'
#22: 
Fixes: 938ce3b16582 ("reset: spacemit: Add SpacemiT K3 reset driver)

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

total: 0 errors, 2 warnings, 0 checks, 220 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 7621b8c4a882 ("reset: spacemit: k3: Decouple composite reset lines") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 220 lines checked
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
WARNING: Please use correct Fixes: style 'Fixes: <12+ chars of sha1> ("<title line>")' - ie: 'Fixes: 938ce3b16582 ("reset: spacemit: Add SpacemiT K3 reset driver")'

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.54 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 1.19 seconds
Result: ERROR
Output:

Commit: 7621b8c4a8826 ("reset: spacemit: k3: Decouple composite reset lines")
	Fixes tag: Fixes: 938ce3b16582 ("reset: spacemit: Add SpacemiT K3 reset driver)
	Has these problem(s):
		- Subject has leading but no trailing quotes
Problems with Fixes tag: 1

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 14, 2026

Patch 1: "[v2] reset: spacemit: k3: Decouple composite reset lines"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1066670 branch March 17, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@linux-riscv-bot