[PW_SID:1071424] [01/26] xor: assert that xor_blocks is not from preemptible user context by linux-riscv-bot · Pull Request #1663 · linux-riscv/linux

linux-riscv-bot · 2026-03-24T06:45:14Z

PR for series 1071424 applied to workflow__riscv__fixes

Name: [01/26] xor: assert that xor_blocks is not from preemptible user context
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1071424
Version: 1

Most of the optimized xor_blocks versions require FPU/vector registers, which generally are not supported in interrupt context. Both callers already are in user context, so enforce this at the highest level. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

xor_blocks can't be called from interrupt context, so remove the handling for that. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Since commit c055e3e ("crypto: xor - use ktime for template benchmarking") the benchmarking works just fine even for TT_MODE_INFCPU, so drop the workarounds. Note that for CPUs supporting AVX2, which includes almost everything built in the last 10 years, the AVX2 implementation is forced anyway. CONFIG_X86_32 is always correctly set for UM in arch/x86/um/Kconfig, so don't override it either. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Richard Weinberger <richard@nod.at> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Update the to of file comment to be correct and non-redundant, and drop the unused BH_TRACE define. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Originally, the XOR code benchmarked all algorithms at load time, but it has since then been hacked multiple times to allow forcing an algorithm, and then commit 524ccdb ("crypto: xor - defer load time benchmark to a later time") changed the logic to a two-step process or registration and benchmarking, but only when built-in. Rework this, so that the XOR_TRY_TEMPLATES macro magic now always just deals with adding the templates to the list, and benchmarking is always done in a second pass; for modular builds from module_init, and for the built-in case using a separate init call level. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Keep xor.h for the public API, and split the struct xor_block_template definition that is only needed by the xor.ko core and architecture-specific optimizations into a separate xor_impl.h header. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Drop the pretty confusing historic XOR_TRY_TEMPLATES and XOR_SELECT_TEMPLATE, and instead let the architectures provide a arch_xor_init that calls either xor_register to register candidates or xor_force to force a specific implementation. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the generic implementations from asm-generic/xor.h to per-implementaion .c files in lib/raid. This will build them unconditionally even when an architecture forces a specific implementation, but as we'll need at least one generic version for the static_call optimization later on we'll pay that price. Note that this would cause the second xor_block_8regs instance created by arch/arm/lib/xor-neon.c to be generated instead of discarded as dead code, so add a NO_TEMPLATE symbol to disable it for this case. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the optimized XOR code out of line into lib/raid. Note that the giant inline assembly block might be better off as a separate assembly source file now, but I'll leave that to the alpha maintainers. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Magnus Lindholm <linmag7@gmail.com> Tested-by: Magnus Lindholm <linmag7@gmail.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the optimized XOR into lib/raid and include it it in the main xor.ko instead of building a separate module for it. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the optimized XOR into lib/raid and include it it in the main xor.ko instead of building a separate module for it. Note that this drops the CONFIG_KERNEL_MODE_NEON dependency, as that is always set for arm64. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the optimized XOR into lib/raid and include it it in xor.ko instead of always building it into the main kernel image. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the optimized XOR into lib/raid and include it it in xor.ko instead of always building it into the main kernel image. The code should probably be split into separate files for the two implementations, but for now this just does the trivial move. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the optimized XOR into lib/raid and include it it in xor.ko instead of unconditionally building it into the main kernel image. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the optimized XOR code out of line into lib/raid. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Remove the inner xor_block_templates, and instead have two separate actual template that call into the neon-enabled compilation unit. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Move the asm/xor.h headers to lib/raid/xor/$(SRCARCH)/xor_arch.h and include/linux/raid/xor_impl.h to lib/raid/xor/xor_impl.h so that the xor.ko module implementation is self-contained in lib/raid/. As this remove the asm-generic mechanism a new kconfig symbol is added to indicate that a architecture-specific implementations exists, and xor_arch.h should be included. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

xor_blocks is very annoying to use, because it is limited to 4 + 1 sources / destinations, has an odd argument order and is completely undocumented. Lift the code that loops around it from btrfs and async_tx/async_xor into common code under the name xor_gen and properly document it. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Replace use of the loop around xor_blocks with the easier to use xor_gen API. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Use the new xor_gen helper instead of open coding the loop around xor_blocks. This helper is very similar to the existing run_xor helper in btrfs, except that the destination buffer is passed explicitly. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: David Sterba <dsterba@suse.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Currently the high-level xor code chunks up all operations into small units for only up to 1 + 4 vectors, and passes it to four different methods. This means the FPU/vector context is entered and left a lot for wide stripes, and a lot of indirect expensive indirect calls are performed. Switch to passing the entire gen_xor request to the low-level ops, and provide a macro to dispatch it to the existing helper. This reduce the number of indirect calls and FPU/vector context switches by a factor approaching nr_stripes / 4, and also reduces source and binary code size. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Avoid the indirect call for xor_generation by using a static_call. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

Add a test case for the XOR routines loosely based on the CRC kunit test. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2026-03-24T06:51:50Z

Patch 1: "[01/26] xor: assert that xor_blocks is not from preemptible user context"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 136.63 seconds
Result: PASS

linux-riscv-bot · 2026-03-24T07:08:49Z

Patch 1: "[01/26] xor: assert that xor_blocks is not from preemptible user context"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1016.65 seconds
Result: PASS

linux-riscv-bot · 2026-03-24T07:31:45Z

Patch 1: "[01/26] xor: assert that xor_blocks is not from preemptible user context"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1374.98 seconds
Result: PASS

linux-riscv-bot · 2026-03-24T07:32:14Z

Patch 1: "[01/26] xor: assert that xor_blocks is not from preemptible user context"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.74 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T00:58:19Z

Patch 24: "[24/26] xor: pass the entire operation to the low-level ops"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T00:58:20Z

Patch 24: "[24/26] xor: pass the entire operation to the low-level ops"
module-param
Desc: Detect module_param changes
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T00:58:22Z

Patch 24: "[24/26] xor: pass the entire operation to the low-level ops"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T00:58:24Z

Patch 24: "[24/26] xor: pass the entire operation to the low-level ops"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:00:55Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.06 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:17:54Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1017.91 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:40:49Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1373.97 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:41:16Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.52 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:41:44Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.44 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:41:46Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.73 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:43:11Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.31 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:43:13Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:43:15Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
kdoc
Desc: Detects for kdoc errors
Duration: 0.84 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:43:17Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:43:19Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:43:21Z

Patch 25: "[25/26] xor: use static_call for xor_gen"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T01:45:52Z

Patch 26: "[26/26] xor: add a kunit test case"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.22 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:04:29Z

Patch 26: "[26/26] xor: add a kunit test case"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1115.22 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:31:33Z

Patch 26: "[26/26] xor: add a kunit test case"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1623.22 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:32:01Z

Patch 26: "[26/26] xor: add a kunit test case"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.66 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:32:29Z

Patch 26: "[26/26] xor: add a kunit test case"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.56 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:32:33Z

Patch 26: "[26/26] xor: add a kunit test case"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.76 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#40: FILE: lib/raid/Kconfig:21:
+config XOR_KUNIT_TEST
+	tristate "KUnit tests for xor_gen" if !KUNIT_ALL_TESTS
+	depends on KUNIT
+	depends on XOR_BLOCKS
+	default KUNIT_ALL_TESTS
+	help
+	  Unit tests for the XOR library functions.
+
+	  This is intended to help people writing architecture-specific
+	  optimized versions.  If unsure, say N.

CHECK: Alignment should match open parenthesis
#111: FILE: lib/raid/xor/tests/xor_kunit.c:34:
+static void xor_ref(void *dest, void **srcs, unsigned int src_cnt,
+		unsigned int bytes)

CHECK: Alignment should match open parenthesis
#197: FILE: lib/raid/xor/tests/xor_kunit.c:120:
+		KUNIT_EXPECT_MEMEQ_MSG(test, test_ref + align,
+				test_dest + align, len,

CHECK: Please use a blank line after function/struct/union/enum declarations
#261: FILE: lib/raid/xor/tests/xor_kunit.c:184:
+};
+kunit_test_suite(xor_test_suite);

total: 0 errors, 2 warnings, 3 checks, 215 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit c0fe2371448e ("xor: add a kunit test case") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 3 checks, 215 lines checked
CHECK: Alignment should match open parenthesis
CHECK: Please use a blank line after function/struct/union/enum declarations
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

linux-riscv-bot · 2026-03-25T02:33:58Z

Patch 26: "[26/26] xor: add a kunit test case"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.66 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:34:00Z

Patch 26: "[26/26] xor: add a kunit test case"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:34:02Z

Patch 26: "[26/26] xor: add a kunit test case"
kdoc
Desc: Detects for kdoc errors
Duration: 0.93 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:34:04Z

Patch 26: "[26/26] xor: add a kunit test case"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:34:06Z

Patch 26: "[26/26] xor: add a kunit test case"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

linux-riscv-bot · 2026-03-25T02:34:07Z

Patch 26: "[26/26] xor: add a kunit test case"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Christoph Hellwig added 26 commits March 24, 2026 06:45

arm/xor: remove in_interrupt() handling

eb7fb83

xor_blocks can't be called from interrupt context, so remove the handling for that. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

xor: move to lib/raid/

27ad6ff

Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

xor: small cleanups

b147b81

Update the to of file comment to be correct and non-redundant, and drop the unused BH_TRACE define. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

arm: move the XOR code to lib/raid/

36efb00

Move the optimized XOR into lib/raid and include it it in the main xor.ko instead of building a separate module for it. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

loongarch: move the XOR code to lib/raid/

7676c3a

Move the optimized XOR into lib/raid and include it it in xor.ko instead of always building it into the main kernel image. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

powerpc: move the XOR code to lib/raid/

cece8b2

Move the optimized XOR into lib/raid and include it it in xor.ko instead of always building it into the main kernel image. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

riscv: move the XOR code to lib/raid/

1f260a3

Move the optimized XOR into lib/raid and include it it in xor.ko instead of always building it into the main kernel image. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

x86: move the XOR code to lib/raid/

80900d2

Move the optimized XOR code out of line into lib/raid. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

async_xor: use xor_gen

9e069b9

Replace use of the loop around xor_blocks with the easier to use xor_gen API. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

xor: use static_call for xor_gen

e11e13d

Avoid the indirect call for xor_generation by using a static_call. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

xor: add a kunit test case

c0fe237

Add a test case for the XOR routines loosely based on the CRC kunit test. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot closed this Apr 1, 2026

linux-riscv-bot deleted the pw1071424 branch April 1, 2026 00:05

Conversation

linux-riscv-bot commented Mar 24, 2026

Uh oh!

linux-riscv-bot commented Mar 24, 2026

Uh oh!

linux-riscv-bot commented Mar 24, 2026

Uh oh!

linux-riscv-bot commented Mar 24, 2026

Uh oh!

linux-riscv-bot commented Mar 24, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

linux-riscv-bot commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant