Skip to content

[PW_SID:1072423] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()#1669

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1072423
Closed

[PW_SID:1072423] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()#1669
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1072423

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Mar 25, 2026

PR for series 1072423 applied to workflow__riscv__fixes

Name: phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1072423
Version: 1

@outman119
phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()
1944115 
When clk_enable() fails, the clock was never enabled. Calling
clk_disable() in this error path is incorrect.

Remove the spurious clk_disable() call from the error handling
in spacemit_usb2phy_init().

Fixes: fe4bc1a ("phy: spacemit: support K1 USB2.0 PHY controller")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 136.78 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1022.47 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1390.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.02 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.39 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 84.48 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Mar 25, 2026

Patch 1: "phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1072423 branch March 25, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @outman119