Skip to content

[PW_SID:1073221] riscv: panic from init_IRQ if IRQ handler stacks cannot be allocated #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
linux-riscv-bot wants to merge 1 commit into from
Closed

[PW_SID:1073221] riscv: panic from init_IRQ if IRQ handler stacks cannot be allocated #1673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 32 additions & 11 deletions arch/riscv/kernel/irq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* Copyright (C) 2018 Christoph Hellwig
*/

#include <linux/errno.h>
#include <linux/interrupt.h>
#include <linux/irqchip.h>
#include <linux/irqdomain.h>
Expand Down Expand Up @@ -75,41 +76,53 @@ DECLARE_PER_CPU(ulong *, irq_shadow_call_stack_ptr);
DEFINE_PER_CPU(ulong *, irq_shadow_call_stack_ptr);
#endif

static void init_irq_scs(void)
static int __init init_irq_scs(void)
{
int cpu;
void *s;

if (!scs_is_enabled())
return;
return 0;

for_each_possible_cpu(cpu)
per_cpu(irq_shadow_call_stack_ptr, cpu) =
scs_alloc(cpu_to_node(cpu));
for_each_possible_cpu(cpu) {
s = scs_alloc(cpu_to_node(cpu));
if (!s)
return -ENOMEM;
per_cpu(irq_shadow_call_stack_ptr, cpu) = s;
}

return 0;
}

DEFINE_PER_CPU(ulong *, irq_stack_ptr);

#ifdef CONFIG_VMAP_STACK
static void init_irq_stacks(void)
static int __init init_irq_stacks(void)
{
int cpu;
ulong *p;

for_each_possible_cpu(cpu) {
p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, cpu_to_node(cpu));
if (!p)
return -ENOMEM;
per_cpu(irq_stack_ptr, cpu) = p;
}

return 0;
}
#else
/* irq stack only needs to be 16 byte aligned - not IRQ_STACK_SIZE aligned. */
DEFINE_PER_CPU_ALIGNED(ulong [IRQ_STACK_SIZE/sizeof(ulong)], irq_stack);

static void init_irq_stacks(void)
static int __init init_irq_stacks(void)
{
int cpu;

for_each_possible_cpu(cpu)
per_cpu(irq_stack_ptr, cpu) = per_cpu(irq_stack, cpu);

return 0;
}
#endif /* CONFIG_VMAP_STACK */

Expand All @@ -129,8 +142,15 @@ void do_softirq_own_stack(void)
#endif /* CONFIG_SOFTIRQ_ON_OWN_STACK */

#else
static void init_irq_scs(void) {}
static void init_irq_stacks(void) {}
static int __init init_irq_scs(void)
{
return 0;
}

static int __init init_irq_stacks(void)
{
return 0;
}
#endif /* CONFIG_IRQ_STACKS */

int arch_show_interrupts(struct seq_file *p, int prec)
Expand All @@ -141,8 +161,9 @@ int arch_show_interrupts(struct seq_file *p, int prec)

void __init init_IRQ(void)
{
init_irq_scs();
init_irq_stacks();
if (init_irq_stacks() || init_irq_scs())
panic("Failed to allocate IRQ stack resources\n");

irqchip_init();
if (!handle_arch_irq)
panic("No interrupt controller found.");
Expand Down