[PW_SID:1074409] RISC-V: KVM: Fix hugepage mapping handling during dirty logging by linux-riscv-bot · Pull Request #1692 · linux-riscv/linux

linux-riscv-bot · 2026-03-31T01:55:15Z

PR for series 1074409 applied to workflow__riscv__fixes

Name: RISC-V: KVM: Fix hugepage mapping handling during dirty logging
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1074409
Version: 4

Fix various typos in RISC-V architecture code and comments. The following changes are included: - arch/riscv/errata/thead/errata.c: "futher" → "further" - arch/riscv/include/asm/atomic.h: "therefor" → "therefore", "arithmatic" → "arithmetic" - arch/riscv/include/asm/elf.h: "availiable" → "available", "coorespends" → "corresponds" - arch/riscv/include/asm/processor.h: "requries" → "is required" - arch/riscv/include/asm/thread_info.h: "returing" → "returning" - arch/riscv/kernel/acpi.c: "compliancy" → "compliance" - arch/riscv/kernel/ftrace.c: "therefor" → "therefore" - arch/riscv/kernel/head.S: "intruction" → "instruction" - arch/riscv/kernel/mcount-dyn.S: "localtion → "location" - arch/riscv/kernel/module-sections.c: "maxinum" → "maximum" - arch/riscv/kernel/probes/kprobes.c: "reenabled" → "re-enabled" - arch/riscv/kernel/probes/uprobes.c: "probbed" → "probed" - arch/riscv/kernel/soc.c: "extremly" → "extremely" - arch/riscv/kernel/suspend.c: "incosistent" → "inconsistent" - arch/riscv/kvm/tlb.c: "cahce" → "cache" - arch/riscv/kvm/vcpu_pmu.c: "indicies" → "indices" - arch/riscv/lib/csum.c: "implmentations" → "implementations" - arch/riscv/lib/memmove.S: "ammount" → "amount" - arch/riscv/mm/cacheflush.c: "visable" → "visible" - arch/riscv/mm/physaddr.c: "aginst" → "against" Signed-off-by: Sean Chang <seanwascoding@gmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Link: https://patch.msgid.link/20260212163325.60389-1-seanwascoding@gmail.com Signed-off-by: Paul Walmsley <pjw@kernel.org>

Commit f1a0a37 ("sched/core: Initialize the idle task with preemption disabled") removed a call to preempt_disable(), but not the associated comment. Remove the outdated comment. Fixes: f1a0a37 ("sched/core: Initialize the idle task with preemption disabled") Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn> Link: https://patch.msgid.link/20260204-riscv-smp-comment-update-2026-01-v1-1-8b77aa181530@iscas.ac.cn Signed-off-by: Paul Walmsley <pjw@kernel.org>

local_flush_icache_all() only flushes and synchronizes the *instruction* cache, not the data cache. Since RISC-V does have a cbo.flush instruction for data cache flush, clarify the comment to avoid confusion. Fixes: 58661a3 ("riscv: Flush the instruction cache during SMP bringup") Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn> Link: https://patch.msgid.link/20260204-riscv-smp-comment-update-2026-01-v1-2-8b77aa181530@iscas.ac.cn Signed-off-by: Paul Walmsley <pjw@kernel.org>

The kaslr_offset() function is a simple accessor that returns kernel_map.virt_offset. This commit change also ensures that kaslr_offset() is consistently available across various kernel configurations without requiring explicit linkage to mm/init.c. Signed-off-by: Austin Kim <austin.kim@lge.com> Link: https://patch.msgid.link/aYwJ76yHaMbbQVJA@adminpc-PowerEdge-R7525 Signed-off-by: Paul Walmsley <pjw@kernel.org>

The following options are required by the kdump crash utility for RISC-V based vmcore file: - kaslr: If the vmcore is generated from a KASLR-enabled Linux kernel, the KASLR offset is required for the crash utility to load the vmcore. Without the proper kaslr option, the crash utility fails to load the vmcore file. - satp: The exact root page table address helps determine the correct base PGD address. With this patch, RISC-V VMCOREINFO ELF notes now include both kaslr and satp information. Signed-off-by: Austin Kim <austin.kim@lge.com> Link: https://patch.msgid.link/aYwKUE3ZzN7/ZY/A@adminpc-PowerEdge-R7525 Signed-off-by: Paul Walmsley <pjw@kernel.org>

Fix several bugs in the RISC-V kgdb implementation: - The element of dbg_reg_def[] that is supposed to pertain to the S1 register embeds instead the struct pt_regs offset of the A1 register. Fix this to use the S1 register offset in struct pt_regs. - The sleeping_thread_to_gdb_regs() function copies the value of the S10 register into the gdb_regs[] array element meant for the S9 register, and copies the value of the S11 register into the array element meant for the S10 register. It also neglects to copy the value of the S11 register. Fix all of these issues. Fixes: fe89bd2 ("riscv: Add KGDB support") Cc: Vincent Chen <vincent.chen@sifive.com> Link: https://patch.msgid.link/fde376f8-bcfd-bfe4-e467-07d8f7608d05@kernel.org Signed-off-by: Paul Walmsley <pjw@kernel.org>

Similarly to commit 8d09e2d ("arm64: patching: avoid early page_to_phys()"), avoid using phys_to_page() for the kernel address case in patch_map(). Since this is called from apply_boot_alternatives() in setup_arch(), and commit 4267739 ("arch, mm: consolidate initialization of SPARSE memory model") has moved sparse_init() to after setup_arch(), phys_to_page() is not available there yet, and it panics on boot with SPARSEMEM on RV32, which does not use SPARSEMEM_VMEMMAP. Reported-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Closes: https://lore.kernel.org/r/20260223144108-dcace0b9-02e8-4b67-a7ce-f263bed36f26@linutronix.de/ Fixes: 4267739 ("arch, mm: consolidate initialization of SPARSE memory model") Suggested-by: Mike Rapoport <rppt@kernel.org> Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Tested-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Link: https://patch.msgid.link/20260310-riscv-sparsemem-alternatives-fix-v1-1-659d5dd257e2@iscas.ac.cn [pjw@kernel.org: fix the subject line to align with the patch description] Signed-off-by: Paul Walmsley <pjw@kernel.org>

The BITS variable conveniently allows to simplify the assignment for UTS_MACHINE. Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com> Link: https://patch.msgid.link/20260313164012.1153936-2-u.kleine-koenig@baylibre.com Signed-off-by: Paul Walmsley <pjw@kernel.org>

The BIT() macros is used by the validate_v_ptrace() test case, but not defined. Include linux/bits.h to pull in this definition. To ensure that the header in the kernel source is used, add tools/include to the header search path. Fixes: 30eb191 ("selftests: riscv: verify ptrace rejects invalid vector csr inputs") Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com> Reviewed-and-tested-by: Sergey Matyukevich <geomatsi@gmail.com> Link: https://patch.msgid.link/20260309-fix_selftests-v2-1-9d5a553a531e@gmail.com Signed-off-by: Paul Walmsley <pjw@kernel.org>

BIT() is being used in ptrace.h without a definition, resulting in compilation errors in tools/testing/selftests/riscv/cfi/cfitests.c: cfitests.c:101:60: error: implicit declaration of function ‘BIT’ [-Wimplicit-function-declaration] 101 | if ((cfi_reg.cfi_status.cfi_state & CFI_ENABLE_MASK) != CFI_ENABLE_MASK) Include linux/bits.h to resolve this issue. Fixes: 2af7c9c ("riscv/ptrace: expose riscv CFI status and state via ptrace and in core files") Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com> Reviewed-by: Deepak Gupta <debug@rivosinc.com> Link: https://patch.msgid.link/20260309-fix_selftests-v2-3-9d5a553a531e@gmail.com Signed-off-by: Paul Walmsley <pjw@kernel.org>

The cfi selftest was missing a license so add it. Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com> Reviewed-by: Deepak Gupta <debug@rivosinc.com> Link: https://patch.msgid.link/20260309-fix_selftests-v2-4-9d5a553a531e@gmail.com Signed-off-by: Paul Walmsley <pjw@kernel.org>

…ging When enabling dirty log in small chunks (e.g., QEMU default chunk size of 256K), the chunk size is always smaller than the page size of huge pages (1G or 2M) used in the gstage page tables. This caused the write protection to be incorrectly skipped for huge PTEs because the condition `(end - addr) >= page_size` was not satisfied. Remove the size check in `kvm_riscv_gstage_wp_range()` to ensure huge PTEs are always write-protected regardless of the chunk size. Additionally, explicitly align the address down to the page size before invoking `kvm_riscv_gstage_op_pte()` to guarantee that the address passed to the operation function is page-aligned. This fixes the issue where dirty pages might not be tracked correctly when using huge pages. Fixes: 9d05c1f ("RISC-V: KVM: Implement stage2 page table programming") Signed-off-by: Wang Yechao <wang.yechao255@zte.com.cn> Reviewed-by: Nutty Liu <nutty.liu@hotmail.com> Reviewed-by: Anup Patel <anup@brainfault.org> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

…or dirty logging During dirty logging, all huge pages are write-protected. When the guest writes to a write-protected huge page, a page fault is triggered. Before recovering the write permission, the huge page must be split into smaller pages (e.g., 4K). After splitting, the normal mapping process proceeds, allowing write permission to be restored at the smaller page granularity. If dirty logging is disabled because migration failed or was cancelled, only recover the write permission at the 4K level, and skip recovering the huge page mapping at this time to avoid the overhead of freeing page tables. The huge page mapping can be recovered in the ioctl context, similar to x86, in a later patch. Signed-off-by: Wang Yechao <wang.yechao255@zte.com.cn> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2026-03-31T02:01:40Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.60 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:18:46Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1023.80 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:41:59Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1391.61 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:42:29Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 27.37 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:42:59Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.32 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:43:01Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.80 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:44:27Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 85.02 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:44:29Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:44:32Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
kdoc
Desc: Detects for kdoc errors
Duration: 0.82 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:44:33Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:44:35Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:44:37Z

Patch 1: "[v4,1/2] RISC-V: KVM: Fix lost write protection on huge pages during dirty logging"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T02:47:11Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.23 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:04:46Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1053.76 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:28:14Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1406.43 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:28:42Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.78 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:29:12Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.33 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:29:15Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.96 seconds
Result: ERROR
Output:

ERROR: code indent should use tabs where possible
#39: FILE: arch/riscv/include/asm/kvm_gstage.h:57:
+                                struct kvm_mmu_memory_cache *pcache,$

WARNING: please, no spaces at the start of a line
#39: FILE: arch/riscv/include/asm/kvm_gstage.h:57:
+                                struct kvm_mmu_memory_cache *pcache,$

ERROR: code indent should use tabs where possible
#40: FILE: arch/riscv/include/asm/kvm_gstage.h:58:
+                                gpa_t addr, u32 target_level, bool flush);$

WARNING: please, no spaces at the start of a line
#40: FILE: arch/riscv/include/asm/kvm_gstage.h:58:
+                                gpa_t addr, u32 target_level, bool flush);$

ERROR: space required before the open parenthesis '('
#160: FILE: arch/riscv/kvm/gstage.c:299:
+	while(current_level > target_level) {

CHECK: Alignment should match open parenthesis
#188: FILE: arch/riscv/kvm/gstage.c:327:
+		set_pte(ptep, pfn_pte(PFN_DOWN(__pa(next_ptep)),
+				__pgprot(_PAGE_TABLE)));

total: 3 errors, 2 warnings, 1 checks, 161 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

Commit 87c16ba0617c (" [PATCH v4 2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
CHECK: Alignment should match open parenthesis
ERROR: code indent should use tabs where possible
ERROR: space required before the open parenthesis '('
WARNING: please, no spaces at the start of a line

linux-riscv-bot · 2026-03-31T03:30:40Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.76 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:30:42Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:30:44Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:30:50Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
module-param
Desc: Detect module_param changes
Duration: 4.00 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:30:52Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.32 seconds
Result: PASS

linux-riscv-bot · 2026-03-31T03:30:54Z

Patch 2: "[v4,2/2] RISC-V: KVM: Split huge pages during fault handling for dirty logging"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

Sean Chang and others added 14 commits February 18, 2026 20:49

Adding CI files

c315cbf

linux-riscv-bot force-pushed the workflow__riscv__fixes branch 4 times, most recently from 2830afe to 506e7f6 Compare April 5, 2026 01:35

linux-riscv-bot closed this Apr 7, 2026

linux-riscv-bot deleted the pw1074409 branch April 7, 2026 00:05

Conversation

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

linux-riscv-bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants