Skip to content

[PW_SID:1078136] riscv: Fix fast_unaligned_access_speed_key not getting initialized#1736

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1078136
Closed

[PW_SID:1078136] riscv: Fix fast_unaligned_access_speed_key not getting initialized#1736
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1078136

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

PR for series 1078136 applied to workflow__riscv__fixes

Name: riscv: Fix fast_unaligned_access_speed_key not getting initialized
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1078136
Version: 1

The static key fast_unaligned_access_speed_key is supposed to be
initialized after check_unaligned_access_all_cpus() has been completed.

However, check_unaligned_access_all_cpus() has been moved to late_initcall
while setting fast_unaligned_access_speed_key still happens at
arch_initcall_sync, thus the static key does not get properly initialized.

fast_unaligned_access_speed_key can still be initialized in CPU hotplug
events, but that cannot be relied on.

Move fast_unaligned_access_speed_key's initialization into
check_unaligned_access_all_cpus() to fix this issue. This also prevent
someone from moving one initcall while forgetting the other in the future.

Fixes: 6455c6c ("riscv: Clean up & optimize unaligned scalar access probe")
Reported-by: Michael Neuling <mikey@neuling.org>
Closes: https://lore.kernel.org/linux-riscv/CAEjGV6y0=bSLp_wrS0uHFj1S2TCRtz4GKzaU5O-L1VV-EL7Nnw@mail.gmail.com/
Signed-off-by: Nam Cao <namcao@linutronix.de>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.34 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1113.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1625.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.03 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.20 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 4.15 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 84.05 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "riscv: Fix fast_unaligned_access_speed_key not getting initialized"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1078136 branch April 15, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants