Skip to content

[PW_SID:1078450] clk: microchip: mpfs-ccc: fix out-of-bounds write#1740

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1078450
Closed

[PW_SID:1078450] clk: microchip: mpfs-ccc: fix out-of-bounds write#1740
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1078450

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Apr 8, 2026

PR for series 1078450 applied to workflow__riscv__fixes

Name: clk: microchip: mpfs-ccc: fix out-of-bounds write
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1078450
Version: 1

clk: microchip: mpfs-ccc: fix out-of-bounds write
6c839eb 
Issue was allocated array size for clk_data.
When clocks are being registered their index is taken from defines in
dt-bindings. The last 2 clocks had their index outside of allocated range.
Two defines (CLK_CCC_DLL0, CLK_CCC_DLL1) were not used and skipped over
which was not taken into account when allocating the array.

This patch is minimal change to resolve the issue.

Issue was found using KASAN when debugging unrelated xdma driver issue.
Consequently fixing this issue also resolved xdma driver issue.

Related dmesg output:
[    0.290703] BUG: KASAN: slab-out-of-bounds in mpfs_ccc_register_outputs.constprop.0+0xd0/0x1fa
[    0.290984] Write of size 8 at addr ffffffe7be6e3ca8 by task swapper/0/1
[    0.291253] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.1.43-linux4microchip+fpga-2023.09 #1
[    0.291482] Hardware name: Skylabs HPC (DT)
[    0.291611] Call Trace:
...
[    0.292999] [<ffffffff808508c8>] mpfs_ccc_register_outputs.constprop.0+0xd0/0x1fa
[    0.293245] [<ffffffff80850b66>] mpfs_ccc_probe+0x174/0x30e
[    0.293437] [<ffffffff808d4af2>] platform_probe+0x74/0xba
...

Fixes: d39fb17 ("clk: microchip: add PolarFire SoC fabric clock support")
Signed-off-by: Aleš Pečnik <ales.pecnik@skylabs.si>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 134.55 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1127.35 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1633.34 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.52 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.00 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.92 seconds
Result: WARNING
Output:

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

total: 0 errors, 1 warnings, 0 checks, 15 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 6c839eb90d93 ("clk: microchip: mpfs-ccc: fix out-of-bounds write") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 15 lines checked
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.97 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 8, 2026

Patch 1: "clk: microchip: mpfs-ccc: fix out-of-bounds write"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1078450 branch April 16, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@linux-riscv-bot