Skip to content

[PW_SID:1085429] [RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator#1813

Closed
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw1085429
Closed

[PW_SID:1085429] [RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator#1813
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw1085429

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Apr 25, 2026

PR for series 1085429 applied to workflow__riscv__fixes

Name: [RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1085429
Version: 1

nathanchance and others added 3 commits April 24, 2026 07:25
@nathanchance
riscv: Define __riscv_copy_{,vec_}{words,bytes}_unaligned() using SYM…
70d3902 
…_TYPED_FUNC_START

After commit 67bdd7b ("riscv: Split out measure_cycles() for
reuse") and commit c03ad15 ("riscv: Reuse measure_cycles() in
check_vector_unaligned_access()"), there are CFI failure when booting
kernels with CONFIG_CFI=y:

  CFI failure at measure_cycles+0x38/0xe0 (target: __riscv_copy_words_unaligned+0x0/0x50; expected type: ...)
  CFI failure at measure_cycles+0x38/0xe0 (target: __riscv_copy_vec_words_unaligned+0x0/0x24; expected type: ...)

The __riscv_copy_*_unaligned() functions are now called indirectly but
they are not defined with SYM_TYPED_FUNC_START, which is required for
assembly functions called indirectly from C to pass CFI checking. Switch
to SYM_TYPED_FUNC_START to clear up the CFI failures.

Fixes: 67bdd7b ("riscv: Split out measure_cycles() for reuse")
Fixes: c03ad15 ("riscv: Reuse measure_cycles() in check_vector_unaligned_access()")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Link: https://patch.msgid.link/20260406-measure_cycles-cfi-failure-v1-1-03e0234ae02f@kernel.org
Signed-off-by: Paul Walmsley <pjw@kernel.org>
Adding CI files
01805bc
@HSM6236
riscv: mm: Verify per-hart ASID bits when using ASID allocator
cca7b14 
RISC-V probes the number of implemented ASID bits in SATP on the boot
hart and enables the ASID allocator based on that result. However, the
privileged spec allows harts to implement fewer ASID bits by hardwiring
the upper bits to zero.

If a secondary hart implements fewer ASID bits than the boot hart while
the ASID allocator is enabled, different Linux ASIDs may alias on that
hart. This can allow stale TLB entries to survive and potentially
corrupt memory.

Verify the number of implemented ASID bits on each CPU as it comes
online, and refuse to online CPUs that support fewer ASID bits than
the boot CPU.

Signed-off-by: Shengming Hu <hu.shengming@zte.com.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 136.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 922.69 seconds
Result: ERROR
Output:

Redirect to /build/tmp.X0Uk7DNykw and /build/tmp.YY0PYs6vhH
Tree base:
01805bc4f902e ("Adding CI files")
Building the whole tree with the patch
error:
Warning: /build/tmplpas8xwx/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c:244 struct __packed mtk_mfg_opp_entry { __le32 freq_khz; __le32 voltage_core; __le32 voltage_sram; __le32 posdiv; __le32 voltage_margin; __le32 power_mw; }; error: Cannot parse struct or union!
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_vec_words_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_vec_bytes_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_words_unaligned'; recompile with -fPIC
ld.lld: error: relocation R_RISCV_32 cannot be used against symbol '__kcfi_typeid___riscv_copy_bytes_unaligned'; recompile with -fPIC



real	15m14.481s
user	569m59.735s
sys	108m1.211s

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1663.81 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.34 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 84.92 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 25, 2026

Patch 1: "[RESEND] riscv: mm: Verify per-hart ASID bits when using ASID allocator"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow__riscv__fixes branch 3 times, most recently from f190ec6 to 2c3b264 Compare May 2, 2026 08:13
@linux-riscv-bot linux-riscv-bot deleted the pw1085429 branch May 3, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linux-riscv-bot @nathanchance @HSM6236