Skip to content

[PW_SID:1085990] riscv32 library enhancements and build fixes#1821

Closed
linux-riscv-bot wants to merge 4 commits into
workflowfrom
pw1085990
Closed

[PW_SID:1085990] riscv32 library enhancements and build fixes#1821
linux-riscv-bot wants to merge 4 commits into
workflowfrom
pw1085990

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

PR for series 1085990 applied to workflow

Name: riscv32 library enhancements and build fixes
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1085990
Version: 7

Linux RISC-V bot and others added 4 commits April 26, 2026 22:07
Add riscv32-specific '__ashldi3()', '__ashrdi3()', and '__lshrdi3()'.
Initially it was intended to fix the following link error observed
when building EFI-enabled kernel with CONFIG_EFI_STUB=y and
CONFIG_EFI_GENERIC_STUB=y:

riscv32-linux-gnu-ld: ./drivers/firmware/efi/libstub/lib-cmdline.stub.o: in function `__efistub_.L49':
__efistub_cmdline.c:(.init.text+0x1f2): undefined reference to `__efistub___ashldi3'
riscv32-linux-gnu-ld: __efistub_cmdline.c:(.init.text+0x202): undefined reference to `__efistub___lshrdi3'

Reported at [1] trying to build https://patchew.org/linux/20260212164413.889625-1-dmantipov@yandex.ru,
tested with 'qemu-system-riscv32 -M virt' only.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603041925.KLKqpK6N-lkp@intel.com [1]
Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Tested-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
Assisted-by: gemini/gemini-3.1-pro-preview sashiko
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Add KUnit tests for '__ashldi3()', '__ashrdi3()', and '__lshrdi3()'
helper functions used to implement 64-bit arithmetic shift left,
arithmetic shift right and logical shift right, respectively,
on a 32-bit CPUs.

Tested with 'qemu-system-riscv32 -M virt' and 'qemu-system-arm -M virt'.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Tested-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
When building vmlinuz.efi with CONFIG_EFI_ZBOOT enabled,
'__lshrdi3()' is also needed to fix yet another link error:

riscv32-linux-gnu-ld: drivers/firmware/efi/libstub/lib-cmdline.stub.o: in function `__efistub_.L49':
__efistub_cmdline.c:(.init.text+0x202): undefined reference to `__efistub___lshrdi3'

And since riscv64 can have CONFIG_EFI_ZBOOT but doesn't need
these library routines, rely on CONFIG_32BIT to manage linking
of lib-ashldi3.o and lib-lshrdi3.o on riscv32 only.

Reported-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
Closes: https://lore.kernel.org/linux-riscv/20260409050018.GA371560@inky.localdomain
Tested-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Assisted-by: gemini/gemini-3.1-pro-preview sashiko
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 140.69 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 942.79 seconds
Result: ERROR
Output:

Redirect to /build/tmp.zjjAJ9RK37 and /build/tmp.0TYBVTuVQq
Tree base:
da65025d17309 ("Adding CI files")
Building the whole tree with the patch
error:
Warning: /build/tmp49g50fr4/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c:245 struct __packed mtk_mfg_opp_entry { __le32 freq_khz; __le32 voltage_core; __le32 voltage_sram; __le32 posdiv; __le32 voltage_margin; __le32 power_mw; }; error: Cannot parse struct or union!
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3



real	15m33.919s
user	583m28.068s
sys	108m52.571s

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1489.90 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.04 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.70 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 3.34 seconds
Result: WARNING
Output:

WARNING: Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format
#22: 
Assisted-by: gemini/gemini-3.1-pro-preview sashiko

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#84: 
new file mode 100644

total: 0 errors, 2 warnings, 0 checks, 139 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit fa8dd380203f ("riscv: add platform-specific double word shifts for riscv32") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 139 lines checked
WARNING: Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 87.98 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
kdoc
Desc: Detects for kdoc errors
Duration: 2.03 seconds
Result: ERROR
Output:

Checking the tree before the patch
Error: Cannot find file arch/riscv/lib/ashldi3.S
Error: Cannot find file arch/riscv/lib/ashrdi3.S
Error: Cannot find file arch/riscv/lib/lshrdi3.S
Checking the tree with the patch
Warning: arch/riscv/lib/ashldi3.S:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * Adopted for the Linux kernel from IPXE project, see
Warning: arch/riscv/lib/ashldi3.S:10 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * Shift left
Warning: arch/riscv/lib/ashrdi3.S:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * Adopted for the Linux kernel from IPXE project, see
Warning: arch/riscv/lib/ashrdi3.S:10 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * Arithmetic shift right
Warning: arch/riscv/lib/lshrdi3.S:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * Adopted for the Linux kernel from IPXE project, see
Warning: arch/riscv/lib/lshrdi3.S:10 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * Logical shift right
Errors and warnings before: 3 this patch: 12
New warnings added
1,3c1,12
< Error: Cannot find file arch/riscv/lib/ashldi3.S
< Error: Cannot find file arch/riscv/lib/ashrdi3.S
< Error: Cannot find file arch/riscv/lib/lshrdi3.S
---
> Warning: arch/riscv/lib/ashldi3.S:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>  * Adopted for the Linux kernel from IPXE project, see
> Warning: arch/riscv/lib/ashldi3.S:10 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>  * Shift left
> Warning: arch/riscv/lib/ashrdi3.S:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>  * Adopted for the Linux kernel from IPXE project, see
> Warning: arch/riscv/lib/ashrdi3.S:10 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>  * Arithmetic shift right
> Warning: arch/riscv/lib/lshrdi3.S:2 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>  * Adopted for the Linux kernel from IPXE project, see
> Warning: arch/riscv/lib/lshrdi3.S:10 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
>  * Logical shift right
Per-file breakdown


@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 1: "[v7,1/3] riscv: add platform-specific double word shifts for riscv32"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 140.56 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 943.41 seconds
Result: ERROR
Output:

Redirect to /build/tmp.artdCP0xyB and /build/tmp.F4r5wWFde3
Tree base:
fa8dd380203f7 ("riscv: add platform-specific double word shifts for riscv32")
Building the whole tree with the patch
error:
Warning: /build/tmp1frs8er2/drivers/pmdomain/mediatek/mtk-mfg-pmdomain.c:245 struct __packed mtk_mfg_opp_entry { __le32 freq_khz; __le32 voltage_core; __le32 voltage_sram; __le32 posdiv; __le32 voltage_margin; __le32 power_mw; }; error: Cannot parse struct or union!
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3
ld.lld: error: ./arch/riscv/kernel/vmlinux.lds:9: symbol not found: __ashldi3



real	15m34.717s
user	583m21.891s
sys	108m27.197s

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1406.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.96 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.40 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

CHECK: Please use a blank line after function/struct/union/enum declarations
#235: FILE: lib/tests/shdi3_kunit.c:172:
+};
+kunit_test_suite(shdi3_test_suite);

total: 0 errors, 1 warnings, 1 checks, 198 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 5af9f5cb2976 ("lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 1 checks, 198 lines checked
CHECK: Please use a blank line after function/struct/union/enum declarations
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 87.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 2: "[v7,2/3] lib: kunit: add tests for __ashldi3(), __ashrdi3(), and __lshrdi3()"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.33 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 140.51 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1096.43 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1690.33 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.36 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.52 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.64 seconds
Result: WARNING
Output:

WARNING: Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format
#20: 
Assisted-by: gemini/gemini-3.1-pro-preview sashiko

total: 0 errors, 1 warnings, 0 checks, 9 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 2176d1d2833c ("riscv: fix building compressed EFI image") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 9 lines checked
WARNING: Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format


@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 88.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

Patch 3: "[v7,3/3] riscv: fix building compressed EFI image"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow branch 9 times, most recently from c4947c7 to 694800f Compare May 2, 2026 00:18
@linux-riscv-bot linux-riscv-bot deleted the pw1085990 branch May 2, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants