Skip to content

[PW_SID:1086857] iommu/riscv: Add hardware dirty tracking for second-stage domains#1830

Closed
linux-riscv-bot wants to merge 12 commits into
workflowfrom
pw1086857
Closed

[PW_SID:1086857] iommu/riscv: Add hardware dirty tracking for second-stage domains#1830
linux-riscv-bot wants to merge 12 commits into
workflowfrom
pw1086857

Conversation

@linux-riscv-bot
Copy link
Copy Markdown

@linux-riscv-bot linux-riscv-bot commented Apr 28, 2026

PR for series 1086857 applied to workflow

Name: iommu/riscv: Add hardware dirty tracking for second-stage domains
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1086857
Version: 1

Linux RISC-V bot and others added 12 commits April 28, 2026 02:09
Adding CI files
50e3f1e
@fangyu0809
iommupt: Add RISC-V Second-stage (iohgatp) page table support
8b84a4f 
Add support for Sv39x4/Sv48x4/Sv57x4 Second-stage page tables used by
the RISC-V IOMMU iohgatp register. The x4 root page table is 16 KiB
instead of the usual 4 KiB, covering 2 extra GPA bits (hw_max_vasz_lg2
= 41/50/59).

Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@tjeznach
iommu/riscv: report iommu capabilities
64fd4c9 
Report RISC-V IOMMU capabilities required by VFIO subsystem
to enable PCIe device assignment.

Signed-off-by: Tomasz Jeznach <tjeznach@rivosinc.com>
Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@zongbox
iommu/riscv: use data structure instead of individual values
4a7bd67 
The parameter will be increased when we need to set up more
bit fields in the device context. Use a data structure to
wrap them up.

Signed-off-by: Zong Li <zong.li@sifive.com>
Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@zongbox
iommu/riscv: support GSCID and GVMA invalidation command
448e572 
This patch adds a ID Allocator for GSCID and a wrap for setting up
GSCID in IOTLB invalidation command.

Set up iohgatp to enable second stage table and flush stage-2 table if
the GSCID is set.

The GSCID of domain should be freed when release domain. GSCID will be
allocated for parent domain in nested IOMMU process.

Signed-off-by: Zong Li <zong.li@sifive.com>
Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@tjeznach
RISC-V: KVM: Enable KVM_VFIO interfaces on RISC-V arch
05b4456 
Enable KVM/VFIO support on RISC-V architecture.

Signed-off-by: Tomasz Jeznach <tjeznach@rivosinc.com>
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@fangyu0809
iommu/riscv: Add domain_alloc_paging_flags for second-stage domain
b313ff5 
Replace .domain_alloc_paging with .domain_alloc_paging_flags so callers
can pass allocation flags to select the appropriate page-table type.

When IOMMU_HWPT_ALLOC_NEST_PARENT or IOMMU_HWPT_ALLOC_DIRTY_TRACKING is
set in @flags, allocate a second-stage (iohgatp) domain.

When @flags is 0 the behaviour is identical to the previous
domain_alloc_paging: first-stage (iosatp) domain.

Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@fangyu0809
iommupt: Don't preset D when RISC-V IOMMU dirty tracking on
db9dae4 
When mapping writable pages, the RISC-V format code currently
pre-sets the PTE D bit unconditionally.

If hardware dirty tracking is active (DC.tc.GADE set), the IOMMU
sets D autonomously on the first write. Pre-setting D makes every
new mapping appear dirty immediately and breaks dirty tracking.

Introduce PT_FEAT_RISCV_DIRTY_TRACKING_ACTIVE and, when set, leave
D cleared for new writable mappings so hardware can capture the
first write. Keep pre-setting D when dirty tracking is inactive.

Only meaningful for second-stage (iohgatp) page tables.

Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@fangyu0809
iommu/riscv: Add dirty tracking support for second-stage domains
cc0abfc 
Add hardware dirty tracking support for second-stage (iohgatp) domains
used in KVM VFIO device pass-through.

The RISC-V IOMMU can automatically set the dirty bit in PTEs on write
access when DC.tc.GADE is set and the hardware has AMO_HWAD capability.
Wire this up to the iommufd dirty tracking interface:

  - riscv_iommu_set_dirty_tracking(): Walks all bonds of the domain and
    sets or clears DC.tc.GADE in each device context entry.

  - riscv_iommu_dirty_ops: Exposes set_dirty_tracking and the generic
    page-table read_and_clear_dirty via IOMMU_PT_DIRTY_OPS(riscv_64).

  - domain_alloc_paging_flags: Assigns dirty_ops to second-stage domains
    when AMO_HWAD is advertised in hardware capabilities.

  - riscv_iommu_capable: Reports IOMMU_CAP_DIRTY_TRACKING when
    AMO_HWAD is present.

Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@fangyu0809
iommu/riscv: Add IOTINVAL.GVMA after updating DDT/PDT entries
2e2c1a6 
Previously, only IOTINVAL.VMA was issued, which is insufficient for
second-stage address translation consistency.

Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@fangyu0809
iommupt: Add RISC-V dirty tracking PTE ops
d80d93d 
Implement the three dirty-tracking hooks required by the generic page
table framework for the RISC-V format:

  pt_entry_is_write_dirty():
    Check the D bit (bit 7) in the PTE.

  pt_entry_make_write_clean():
    Clear the D bit across the full contiguous range.

  pt_entry_make_write_dirty():
    Atomically set D via try_cmpxchg64() on a single PTE.

Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@zongbox
iommu/riscv: support nested iommu for getting iommu hardware information
694f91b 
This patch implements .hw_info operation and the related data
structures for passing the IOMMU hardware capabilities for iommufd.

Signed-off-by: Zong Li <zong.li@sifive.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Fangyu Yu <fangyu.yu@linux.alibaba.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 140.52 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1153.92 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1697.07 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.09 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 84.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
kdoc
Desc: Detects for kdoc errors
Duration: 0.85 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 1: "[RFC,01/11] iommupt: Add RISC-V Second-stage (iohgatp) page table support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 2: "[RFC,02/11] iommu/riscv: report iommu capabilities"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.70 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 2: "[RFC,02/11] iommu/riscv: report iommu capabilities"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1135.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 2: "[RFC,02/11] iommu/riscv: report iommu capabilities"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1678.03 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 2: "[RFC,02/11] iommu/riscv: report iommu capabilities"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.19 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 2: "[RFC,02/11] iommu/riscv: report iommu capabilities"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 28, 2026

Patch 10: "[RFC,10/11] iommupt: Add RISC-V dirty tracking PTE ops"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 139.83 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1178.66 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1740.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.86 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.81 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.05 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 87.33 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
kdoc
Desc: Detects for kdoc errors
Duration: 2.35 seconds
Result: ERROR
Output:

Checking the tree before the patch
Checking the tree with the patch
Warning: include/uapi/linux/iommufd.h:676 struct member '__reserved' not described in 'iommu_hw_info_riscv_iommu'
Warning: include/uapi/linux/iommufd.h:676 struct member '__reserved' not described in 'iommu_hw_info_riscv_iommu'
Errors and warnings before: 0 this patch: 2
New warnings added
0a1,2
> Warning: include/uapi/linux/iommufd.h:676 struct member '__reserved' not described in 'iommu_hw_info_riscv_iommu'
> Warning: include/uapi/linux/iommufd.h:676 struct member '__reserved' not described in 'iommu_hw_info_riscv_iommu'
Per-file breakdown

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Copy Markdown
Author

linux-riscv-bot commented Apr 29, 2026

Patch 11: "[RFC,11/11] iommu/riscv: support nested iommu for getting iommu hardware information"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot force-pushed the workflow branch 15 times, most recently from 9cacb03 to 8635215 Compare May 6, 2026 02:04
@linux-riscv-bot linux-riscv-bot deleted the pw1086857 branch May 6, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@linux-riscv-bot @fangyu0809 @tjeznach @zongbox